conda-forge / qt-webengine-feedstock

A conda-smithy repository for qt-webengine.
BSD 3-Clause "New" or "Revised" License
1 stars 14 forks source link

5.15.13 #48

Open adrianinsaval opened 6 months ago

adrianinsaval commented 6 months ago

Checklist

conda-forge-webservices[bot] commented 6 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

This has been deprecated in favor of the top-level `test` field.
It is now mapped to `test: native_and_emulated`.
        Failed validating 'deprecated' in schema['properties']['test_on_native_only']:
            {'anyOf': [{'type': 'boolean'}, {'type': 'null'}],
             'default': False,
             'deprecated': True,
             'description': 'This was used for disabling testing for '
                            'cross-compiling.\n'
                            '\n'
                            '```warning\n'
                            'This has been deprecated in favor of the top-level '
                            '`test` field.\n'
                            'It is now mapped to `test: native_and_emulated`.\n'
                            '```',
             'title': 'Test On Native Only'}

        On instance['test_on_native_only']:
            True
adrianinsaval commented 6 months ago

I tried building locally osx_arm64 but I had trouble because it looks like there are no python2 packages for it. Couldn't run the aarch64 build with docker either due to some weird errors about symlinks: OSError: [Errno 40] Too many levels of symbolic links: '/home/conda/feedstock_root/build_artifacts/pkg_cache/ncurses-6.4-h0425590_2/share/terminfo/n/ncr260vt300wpp'

I will try now installing python2 via pyenv and adding that to the path to build webengine on osx_arm64 locally

adrianinsaval commented 6 months ago

I've got builds for osx_644 and linux_64: https://anaconda.org/freecad/qt-webengine/files

still can't figure out how to get a build for osx_arm64, trying to build linux_aarch64 crosscompiled from x86_64

Is it possible to increase the timeout for the ci? maybe it'll work without needing more intervention

adrianinsaval commented 6 months ago

builds for the 5 platforms, what's the next step @hmaarrfk

hmaarrfk commented 6 months ago

trying to build linux_aarch64 crosscompiled from x86_64

this is what i do too.

Is it possible to increase the timeout for the ci? maybe it'll work without needing more intervention

We have some other big machine CIs, but I don't think it will be enough for this. I'm not very good at using them, and to me they are still rather experimental.

builds for the 5 platforms, what's the next step @hmaarrfk

Did you happen to save the log files? We would technically need to follow: https://github.com/conda-forge/cfep/blob/main/cfep-03.md

I can help on the linux builds, but windows and OSX i don't have access to machines that can do that.

hmaarrfk commented 6 months ago

I also somewhat want to get:

https://github.com/conda-forge/qt-main-feedstock/pull/245 https://github.com/conda-forge/qt-main-feedstock/pull/244

mereged in before the 5.15 upgrade since it seems that it will unblock the mysql pin or i guess we can do the 5.15.13 pin along with the mysql upgrade if you want to merge in my changes. No need to merge in the rerenders

hmaarrfk commented 6 months ago

Ok this is really awesome work. I think the way to go will be:

  1. [ ] I would like to pin qt-main to 5.15.8 at build time to help downstream packages be compatible with both while we build everything out. https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/5670
  2. [ ] Rebase or merge from conda-forge/main your 5.15.13 branch to take in the new changes for mysql 13 and pulseaudio-client 17
  3. [ ] Get qt-main 5.15.13 uploaded to conda-forge https://github.com/conda-forge/cfep/blob/main/cfep-03.md Generally we ask for logs.
  4. [ ] Once we merge I will create a branch for 5.15.8 on qt-main just to have a reference point for migrations in case of any delays.
  5. [ ] Get webengine 5.15.13 uploaded to conda-forge.
  6. [ ] Create "qt" 5.15.13 at https://github.com/conda-forge/qt-feedstock
  7. [ ] Release the build time pin added on the second point.
h-vetinari commented 4 months ago

Any updates on this effort here? 🙃

I think it's gonna be necessary to unblock pyside2 for py312, which is the migration I'm looking at right now.