Use inbuilt icu - Githubissues

conda-forge / qt-webengine-feedstock

A conda-smithy repository for qt-webengine.

BSD 3-Clause "New" or "Revised" License

1 stars 14 forks source link

Use inbuilt icu #8

Closed Tobias-Fischer closed 2 years ago

Tobias-Fischer commented 2 years ago

[x] OSX Build -- Tobias-Fischer
[x] OSX ARM Build -- Tobias-Fischer
[x] Windows Build
[x] Linux Build -- hmaarrfk q server
[x] Linux arm Build -- hmaarrfk cf server

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Tobias-Fischer commented 2 years ago

@conda-forge-admin, please rerender

Tobias-Fischer commented 2 years ago

See conversation in #6 for reasoning about this PR.

In short: All previous qt-webengine builds used inbuilt icu (by mistake) already. However, they pulled in icu as a host dependency (although that system/host icu was not being used). In turn, this constrained the versions of icu that qt-webengine was compatible with - without any reason.

This PR removes the icu dependency so that the inbuilt icu will be used AND the build will be compatible with any conda icu at runtime.

Fixes #6, needed for https://github.com/conda-forge/qt-feedstock/pull/227 to get the latest qt-main and qt-webengine.

Tobias-Fischer commented 2 years ago

This PR would require a rebuild for all platforms.

Tobias-Fischer commented 2 years ago

This PR is ready for review @conda-forge/qt-webengine @andfoy @hmaarrfk

hmaarrfk commented 2 years ago

Ok, i added a delegation list above.

hmaarrfk commented 2 years ago

As a note to others, system provided ICU was never used in previous builds due to a missing compiler flag.

hmaarrfk commented 2 years ago

Linux build: mark.harfouche cfep03 label linux_64.zip

hmaarrfk commented 2 years ago

linux_aarch64.zip

Tobias-Fischer commented 2 years ago

osx-64 build logs: osx-64.zip

build: https://anaconda.org/TobiasRobotics/qt-webengine/files (cfep03 label)

Tobias-Fischer commented 2 years ago

osx-arm64 build logs:

osx-arm64.zip

build: https://anaconda.org/TobiasRobotics/qt-webengine/files (cfep03 label)

hmaarrfk commented 2 years ago

I'm attempting to build windows now. it may take a while.

hmaarrfk commented 2 years ago

Windows build logs: win_64_log.zip

https://anaconda.org/mark.harfouche/qt-webengine/files

hmaarrfk commented 2 years ago

I guess i have to review logs and stuff. Will do tonight.

Tobias-Fischer commented 2 years ago

osx-arm64 build after @isuruf review comment logs: osx-arm64-new.zip

build (force overwritten the previous build as hash did not change): https://anaconda.org/TobiasRobotics/qt-webengine/files (cfep03 label)

hmaarrfk commented 2 years ago

Thanks everybody!