search

conda-forge / quarto-feedstock

A conda-smithy repository for quarto.
BSD 3-Clause "New" or "Revised" License
4 stars 9 forks source link

Remove broken builds #25

Closed mfisher87 closed 1 year ago

mfisher87 commented 1 year ago

Builds affected by #23 should probably be marked broken and removed from conda-forge.

Should be bother backporting the fix to all the broken versions, or just remove them and move forward?

cderv commented 1 year ago

Probably ok to mark the old one as broken.

mfisher87 commented 1 year ago

Just want to clarify, this would mean all these versions would disappear from conda-forge:

EDIT: :warning: I think this patch has always caused this problem, but we should confirm if that's true.

$ conda search "quarto<1.3.427"
Loading channels: done
# Name                       Version           Build  Channel             
quarto                       1.1.145      ha770c72_0  conda-forge         
quarto                       1.2.335      ha770c72_0  conda-forge         
quarto                       1.2.335      ha770c72_1  conda-forge         
quarto                       1.2.335      ha770c72_2  conda-forge         
quarto                       1.2.475      ha770c72_0  conda-forge         
quarto                       1.3.340      ha770c72_0  conda-forge         
quarto                       1.3.353      ha770c72_0  conda-forge         
quarto                       1.3.361      ha770c72_0  conda-forge

There may be some projects that rely on specific versions (maybe because they are working around a bug, or because a later version changes some behavior they rely on), but don't use TinyTeX at all. If that's important, we should probably backport.

EDIT: Maybe a middle ground; just backport our fix to the latest 1.2.x and 1.1.x releases and get rid of everything else?

cderv commented 1 year ago

Oh I see thanks for detailing.

We did not had much report of this issue. So maybe that was not that used among conda users, or they do use latest versions.

EDIT: Maybe a middle ground; just backport our fix to the latest 1.2.x and 1.1.x releases and get rid of everything else?

This seems ok. FWIW we do our patch generally on one version only. so if we found a bug that needs a patch we patch latest release only (so currently 1.3).

With Quarto, currently it is advisable to use latest stable for your project. It is no only new feature but some bug we found along the way.

Anyhow, I understand conda is used to fix environment so this also make sense to patch differently if this is easy enough to do.

I think this patch has always caused this problem, but we should confirm if that's true.

We did also changed (improved) TinyTeX code part in quarto in 1.3 I think, to overcome some issues and bad experience. So maybe this is also appearing since 1.3 only

mfisher87 commented 1 year ago

We did not had much report of this issue. So maybe that was not that used among conda users, or they do use latest versions.

With Quarto, currently it is advisable to use latest stable for your project. It is no only new feature but some bug we found along the way.

Maybe we should just re-package the latest couple of 1.3 releases, and do other backports if/when people complain that a version they relied on was marked broken.

We did also changed (improved) TinyTeX code part in quarto in 1.3 I think, to overcome some issues and bad experience. So maybe this is also appearing since 1.3 only

This would make sense. I came onboard to maintaining this feedstock because I really wanted to see 1.3 on conda-forge, and there were some major changes needed at that point to get packaging working. Major changes + new maintainer = not surprising that this is when it broke! My fingerprints are all over this crime scene :laughing:

mfisher87 commented 1 year ago

Builds to keep:

:memo: When these builds are done, an extra 20 minutes or so need to pass before users can download from anaconda.org

For other versions, let's play it by ear. Backporting this fix to other 1.3.x versions is easy if we decide we want them. 1.2.x would need a bit more testing.

EDIT: Added a doc link to the OP of this issue.

mfisher87 commented 1 year ago

Tested 1.2.475 conda package and it also overwrites the conda environment wholesale with TinyTeX. I guess this issue's been around longer than I thought. Maybe I'm actually innocent! :laughing:

I was hoping 1.2.x wasn't broken so we wouldn't have to remove them, but such is life.

mfisher87 commented 1 year ago

Kicked off the process to resolve this ticket.

mfisher87 commented 1 year ago

The conda-forge admins merged our request to remove the packages. I think they should be gone by end of today.

mfisher87 commented 1 year ago

Verified:

conda search quarto
# Name                       Version           Build  Channel             
quarto                       1.3.427      ha770c72_2  conda-forge         
quarto                       1.3.433      ha770c72_1  conda-forge