Quarto 1.4 has a new `make-installer-dir` for quarto-bld

conda-forge / quarto-feedstock

A conda-smithy repository for quarto.

BSD 3-Clause "New" or "Revised" License

4 stars 9 forks source link

Quarto 1.4 has a new `make-installer-dir` for quarto-bld #33

Closed cderv closed 9 months ago

cderv commented 11 months ago

This means the patch is no more required

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

This closes #27

I haven't check all the boxes above because not sure what to modify or tests. I'll try it if you advise. I am opening this PR to remember to do that for Quarto 1.4 release.

conda-forge-webservices[bot] commented 11 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mfisher87 commented 10 months ago

Hey @cderv apologies for being unresponsive lately, your patience is appreciated :heart:

I still may not get to this for another week or two. Just wanted to make sure you know I've seen this and will get to it at some point soon :) I've got these sitting in my notifications so I don't forget.

mfisher87 commented 10 months ago

I think what I want to do is set up a Quarto 1.4 pre-release branch where we can test this in advance of the release. I haven't done it before, so hopefully I won't get stuck :)

cderv commented 10 months ago

No worries !

Quarto v1.4 is soon to be release, so we can definitely do some prepare work first !

Is there a pre-release or release canditate state for conda feedstock ?

mfisher87 commented 10 months ago

Yes, that's documented here: https://conda-forge.org/docs/maintainer/knowledge_base.html#pre-release-builds

I've used pre-release builds as an end-user before (and I think I may have contributed to that doc page? :point_up:), but have never set up a pre-release build as a feedstock maintainer before.

mdekstrand commented 9 months ago

I was looking into this a bit to see what's needed to get Quarto up to 1.4, and it looks like it's blocking on a Pandoc update, unless the pandoc dependency specification can be relaxed.

mfisher87 commented 9 months ago

Thanks for looking in to this @mdekstrand ! I hope to have more time to help out over the weekend. I don't think I've worked on the Pandoc feedstock before.

SaravananSathyanandhaQC commented 9 months ago

I was looking into this a bit to see what's needed to get Quarto up to 1.4, and it looks like it's blocking on a Pandoc update, unless the pandoc dependency specification can be relaxed.

If you mean getting the pandoc feedstock updated then it's nearly ready - https://github.com/conda-forge/pandoc-feedstock/pull/139

mfisher87 commented 9 months ago

Amazing! Thank you :) I hope to take a stab at releasing 1.4 on Conda Forge this weekend, and that certainly makes my life easier :)

mfisher87 commented 9 months ago

Resolved in #36 ; thank you @cderv and @SaravananSathyanandhaQC !