search

conda-forge / quarto-feedstock

A conda-smithy repository for quarto.
BSD 3-Clause "New" or "Revised" License
4 stars 9 forks source link

`quarto-preview.js` missing in 1.4.557, 1.5.55 #53

Closed mfisher87 closed 2 months ago

mfisher87 commented 3 months ago

Solution to issue cannot be found in the documentation.

Issue

$ quarto preview
<...>
WARNING: No such file or directory (os error 2): readfile '/path/to/miniforge3/envs/envname/share/quarto/preview/quarto-preview.js'
$ ls -1 /path/to/miniforge3/envs/envname/share/quarto/preview/
jats/
quarto-preview.html

The .js file is present in 1.4.550; it was poor testing on my part for #50 I think. I was sure I'd tested preview :confused:

Installed packages

n/a

Environment info

n/a
mfisher87 commented 3 months ago

It's back in 1.5 (#52)

cderv commented 3 months ago

It should have been fixed for 1.4.557 following

Maybe this needs specific adaptation in here ?

This was due to specific dependencies problem in building the JS

cderv commented 3 months ago

And for what it worth, I have it on windows... 

❯ ls C:\Users\chris\miniconda3\envs\myenv\Library\share\quarto\preview\

    Directory: C:\Users\chris\miniconda3\envs\myenv\Library\share\quarto\preview

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d----          31/07/2024    11:07                jats
-a---          27/06/2024    19:01            543 quarto-preview.html
-a---          16/07/2024    18:12         447110 quarto-preview.js

Though somehow this install does not work for me, but that is probably another issue. (first time I try the conda package)

Do we get a new issue on other OS ? 🤔 I see no error on our latest v1.4 build for the web UI. So possibly a conda only thing

cderv commented 3 months ago

I see it builds on the last conda forge run https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=970683&view=logs&j=ced5d8de-8227-5f3f-33a1-45cf1592c45a&t=f7bcb349-6dca-53ba-d88d-1d9963e119ba&l=2200

Not sure why not available then... 🤔

mfisher87 commented 3 months ago

I'm really confused as well.

mfisher87 commented 3 months ago

I was able to reproduce this in a local build. I may have been looking at the wrong build output when I suggested that it wasn't reproducing locally. No other news :)

cderv commented 3 months ago

Do I understand correctly it is missing in latest stable 1.5 too when build for conda ?

Is it missing on windows ? Or in all builds ?

Maybe there is a copy issue - the file being built correctly but not copied to what creates the conda forge bundle 🤔

mfisher87 commented 3 months ago

Thanks for helping look in to this! I'd love to be able to spend more time on this, but $DAY_JOB is taking a lot out of me and my time for open source contributions (volunteer and funded) has been much less than I'd like.

Do I understand correctly it is missing in latest stable 1.5 too when build for conda ?

Correct, but not 1.4.550.

Is it missing on windows ? Or in all builds ?

This still needs to be answered. I was able to confirm the Linux impact by downloading and unzipping tarballs from here: https://anaconda.org/conda-forge/quarto/files We should be able to do the same for the Mac/Win builds.

Maybe there is a copy issue - the file being built correctly but not copied to what creates the conda forge bundle 🤔

This sounds plausible! The logs show the preview build occurring. :thinking:

mfisher87 commented 2 months ago

Restored a patch we used to hackily force the build of the preview script. I thought it was no longer needed, and removed it without testing thoroughly enough.

I apologize, but my time has been fairly limited and I don't yet understand why the upstream change didn't cause the script to be built the way I expected. Any help with this would be greatly appreciated so we can drop this patch.