Add Cython to run requirements

conda-forge / qutip-feedstock

A conda-smithy repository for qutip.

BSD 3-Clause "New" or "Revised" License

0 stars 14 forks source link

Add Cython to run requirements #54

Closed wshanks closed 3 years ago

wshanks commented 3 years ago

This matches the install_requires specified in qutip's setup.py.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Closes #53 by adding Cython to the run dependencies to mirror the install_requires in qutip's setup.py.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

wshanks commented 3 years ago

@conda-forge-admin, please rerender

jakelishman commented 3 years ago

At the time this was opened, it was correct in principle - Cython was listed as a run-time dependency of QuTiP. However, the real "bug" was more in that dependency list; Cython was more like an optional dependency, because you could use almost all the features of QuTiP without it. Now on master (and for the next release), Cython is correctly listed as only needed for run-time compilation, so it's no longer correct for it to be in the recipe.

Thanks for suggesting this, and sorry for the lack of response before now. I'm closing it now since upstream changes have obsoleted the PR, but still thanks.

wshanks commented 3 years ago

Yes, this was a quick fix for #53 with the main goal being that conda install qutip not cause pip check to fail. It is good to hear that with the next release of qutip #53 can be closed.

jakelishman commented 3 years ago

Ah, thanks for reminding me about the issue. I'll close it once we've done the 4.6 release (hopefully within a fortnight or so).