conda-forge / r-igraph-feedstock

A conda-smithy repository for r-igraph.
BSD 3-Clause "New" or "Revised" License
2 stars 10 forks source link

[bot-automerge] r-igraph v1.4.0 #40

Closed regro-cf-autotick-bot closed 1 year ago

regro-cf-autotick-bot commented 1 year ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows no discrepancy with the stated requirements in the meta.yaml.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/4144818152, please use this URL for debugging.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was not passing and not merged.

mfansler commented 1 year ago

Fails on win-64 with undefined isnan. Here's the excerpt:

g++ -std=gnu++11  -I"D:/bld/r-igraph_1676042533067/_h_env/lib/R/include" -DNDEBUG -DUSING_R -I. -Icore -Iinclude -Ivendor -I/mingw64/include/libxml2 -DNDEBUG -DNTIMER -DNPRINT -DINTERNAL_ARPACK -DPRPACK_IGRAPH_SUPPORT -DIGRAPH_THREAD_LOCAL=/**/         -O2 -Wall  -march=x86-64 -mtune=generic  -c core/community/infomap/infomap.cc -o core/community/infomap/infomap.o
In file included from core/core/interruption.h:29:0,
                 from core/community/infomap/infomap.cc:35:
./config.h:116:0: warning: "IGRAPH_THREAD_LOCAL" redefined
 #define IGRAPH_THREAD_LOCAL /**/
 ^
<command-line>:0:0: note: this is the location of the previous definition
core/community/infomap/infomap.cc: In function 'int igraph_community_infomap(const igraph_t*, const igraph_vector_t*, const igraph_vector_t*, int, igraph_vector_t*, igraph_real_t*)':
core/community/infomap/infomap.cc:289:39: error: 'isnan' was not declared in this scope
             } else if (isnan(minweight)) {
                                       ^
core/community/infomap/infomap.cc:289:39: note: suggested alternative:
In file included from core/community/infomap/infomap.cc:32:0:
D:/bld/r-igraph_1676042533067/_h_env/Library/mingw-w64/include/c++/5.3.0/cmath:641:5: note:   'std::isnan'
     isnan(_Tp __x)
     ^
core/community/infomap/infomap.cc:304:39: error: 'isnan' was not declared in this scope
             } else if (isnan(minweight)) {
                                       ^
core/community/infomap/infomap.cc:304:39: note: suggested alternative:
In file included from core/community/infomap/infomap.cc:32:0:
D:/bld/r-igraph_1676042533067/_h_env/Library/mingw-w64/include/c++/5.3.0/cmath:641:5: note:   'std::isnan'
     isnan(_Tp __x)
     ^
make: *** [core/community/infomap/infomap.o] Error 1
D:/bld/r-igraph_1676042533067/_h_env/lib/R/etc/x64/Makeconf:243: recipe for target 'core/community/infomap/infomap.o' failed
ERROR: compilation failed for package 'igraph'
szhorvat commented 1 year ago

This might fix it:

https://github.com/igraph/igraph/commit/7b4219729d6fd16f0a480ae6413738427f58bee3

Can you apply the patch on the conda side and test it? I cannot reproduce the issue locally with GCC 11/12 on macOS. It may have to do with the fact that <cmath> was included before <math.h>, and somehow prevented the full processing of math.h due to a shared header guard? This is a pure guess. If this is what's happening, it might actually be a bug in the toolchain, as math.h and cmath are different ...

CC @ntamas

szhorvat commented 1 year ago

I believe this is a bug in GCC 5 and earlier (or the standard library that comes with it). You can try it here.

https://godbolt.org/z/5r1h9sboE

This does not compile without using std::isnan, unless #include <cmath> is removed.

#include <cmath>
#include <math.h>

int main() { isnan(1.0); return 0; }

Why are you using such an ancient compiler version? GCC 6 is already free of this problem.

mfansler commented 1 year ago

@szhorvat thanks for sharing your insight! Unfortunately, no one regularly updates the Conda Forge m2w64 toolchain. So, it looks like dropping the Windows build until that progresses might be something to consider.

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

It appears that not all commits to this PR were made by the bot. Thus this PR is not being automatically merged. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

mfansler commented 1 year ago

@conda-forge-admin please rerender

szhorvat commented 1 year ago

1.4.1, released today, fixes this issue.