Rework to stop vendoring `tbb`

conda-forge / r-rcppparallel-feedstock

A conda-smithy repository for r-rcppparallel.

BSD 3-Clause "New" or "Revised" License

0 stars 3 forks source link

Rework to stop vendoring `tbb` #29

Open mfansler opened 1 year ago

mfansler commented 1 year ago

This recipe vendors its own copy of tbb (see source). It would be an improvement to gut that part of the package and link against a CF version.

WardBrian commented 4 months ago

I maintain https://github.com/conda-forge/cmdstan-feedstock, which currently also vendors TBB on Windows due to requiring the mingw ABI, same as this package. I'd be interested in collaborating on a feedstock for just that build of TBB if there is still interest here!

I had previously raised this on the tbb-feedstock repository, but it would probably make sense to have as a separate package

wolfv commented 4 months ago

Thanks, I think I noticed multiple things:

multiple packages are vendoring TBB or RCppParallel
the TBB I got was for x64 (not ARM64). Possibly a cross-compilation bug.

I am not super up to speed with this whole ecosystem so not sure how easy these things are to fix.

wolfv commented 4 months ago

I think I saw it with r-stan and r-stanheaders or so.

WardBrian commented 4 months ago

@wolfv - I think you ended up in a different issue than you thought, but as someone decently familiar with the ecosystem, avoiding vendoring is definitely possible (and relatively easy on Mac and Linux). The cmdstan-feedstock uses tbb-devel on those platforms

I stepped into this issue earlier because vendoring is not very easy on Windows, because of ABI requirements in R and Stan