Closed WardBrian closed 2 months ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
@conda-forge-admin, please rerender
@mfansler since b8d2609 passed, I think this will work. It supersedes #30 #31 and #32
The main difference from #30 is that this does not try to unvendor TBB, due to the difficulties discussed in https://github.com/conda-forge/r-rcppparallel-feedstock/issues/29#issuecomment-2194695394, so it can also avoid using r-clang
I still think it would be nice to have something like a tbb-mingw-feedstock
which could be built against the ABI R requires
Ok, the migrator also set the non-x86 linux builds to cross compile on x86. I think this requires an export arch=...
somewhere, but I'm not sure where is best to put it.
Alternatively, we could vendor TBB everywhere except Windows, which is pretty easy to do
@conda-forge-admin, please rerender
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml
) and found some lint.
Here's what I've got...
For recipe/meta.yaml:
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
cc @mfansler (for awareness)
@conda-forge-admin please rerender
@conda-forge-admin please rerender
@conda-forge-admin, please rerender
Hi! This is the friendly conda-forge automerge bot!
I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day!
Thank you both! 🙏
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)Supersedes https://github.com/conda-forge/r-rcppparallel-feedstock/pull/30 https://github.com/conda-forge/r-rcppparallel-feedstock/pull/31 and https://github.com/conda-forge/r-rcppparallel-feedstock/pull/32
The main difference from https://github.com/conda-forge/r-rcppparallel-feedstock/pull/30 is that this does not try to unvendor TBB, due to the difficulties discussed in https://github.com/conda-forge/r-rcppparallel-feedstock/issues/29#issuecomment-2194695394, so it can also avoid using r-clang
I still think it would be nice to have something like a tbb-mingw-feedstock which could be built against the ABI R requires