conda-forge / r-rcppparallel-feedstock

A conda-smithy repository for r-rcppparallel.
BSD 3-Clause "New" or "Revised" License
0 stars 3 forks source link

Rebuild for r-base 4.4 and UCRT mingw toolchain #33

Closed WardBrian closed 2 months ago

WardBrian commented 2 months ago

Checklist

Supersedes https://github.com/conda-forge/r-rcppparallel-feedstock/pull/30 https://github.com/conda-forge/r-rcppparallel-feedstock/pull/31 and https://github.com/conda-forge/r-rcppparallel-feedstock/pull/32

The main difference from https://github.com/conda-forge/r-rcppparallel-feedstock/pull/30 is that this does not try to unvendor TBB, due to the difficulties discussed in https://github.com/conda-forge/r-rcppparallel-feedstock/issues/29#issuecomment-2194695394, so it can also avoid using r-clang

I still think it would be nice to have something like a tbb-mingw-feedstock which could be built against the ABI R requires

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

WardBrian commented 2 months ago

@conda-forge-admin, please rerender

WardBrian commented 2 months ago

@conda-forge-admin, please rerender

WardBrian commented 2 months ago

@mfansler since b8d2609 passed, I think this will work. It supersedes #30 #31 and #32

The main difference from #30 is that this does not try to unvendor TBB, due to the difficulties discussed in https://github.com/conda-forge/r-rcppparallel-feedstock/issues/29#issuecomment-2194695394, so it can also avoid using r-clang

I still think it would be nice to have something like a tbb-mingw-feedstock which could be built against the ABI R requires

WardBrian commented 2 months ago

Ok, the migrator also set the non-x86 linux builds to cross compile on x86. I think this requires an export arch=... somewhere, but I'm not sure where is best to put it.

Alternatively, we could vendor TBB everywhere except Windows, which is pretty easy to do

WardBrian commented 2 months ago

@conda-forge-admin, please rerender

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

WardBrian commented 2 months ago

@conda-forge-admin, please rerender

jakirkham commented 2 months ago

cc @mfansler (for awareness)

mfansler commented 2 months ago

@conda-forge-admin please rerender

mfansler commented 2 months ago

@conda-forge-admin please rerender

WardBrian commented 2 months ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

jakirkham commented 2 months ago

Thank you both! 🙏