Update to 2.18.1 - Githubissues

conda-forge / r-rstan-feedstock

A conda-smithy repository for r-rstan.

BSD 3-Clause "New" or "Revised" License

1 stars 9 forks source link

Closed cbrueffer closed 4 years ago

cbrueffer commented 5 years ago

Checklist

[x] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Using toolchain directly in this manner is deprecated. Consider using the compilers outlined here.

cbrueffer commented 5 years ago

Needs CXX14, do any of the conda-forge compilers support that?

dbast commented 5 years ago

@cbrueffer Good question... maybe it is as easy as the commit i just pushed, if the compile support it.

dbast commented 5 years ago

Ok. setting USE_CXX14=1 in bld scripts does not help ... like documented here https://github.com/stan-dev/rstan/wiki/RStan-Getting-Started

dbast commented 5 years ago

I should have only enabled the "windows build" in https://github.com/conda-forge/r-rstanarm-feedstock/pull/4 and defer the version update. Now the version update is stuck here.

Maybe C++14 works with the GCC7 rebuild that is coming, but according to this also the older compile should support it https://gcc.gnu.org/projects/cxx-status.html#cxx14