conda-forge / rabbitmq-server-feedstock

A conda-smithy repository for rabbitmq-server.
BSD 3-Clause "New" or "Revised" License
1 stars 7 forks source link

Fix parameter passing #31

Closed Anthchirp closed 3 years ago

Anthchirp commented 3 years ago

$* will run parameters through globbing, so the string .* will become a list of filenames. This means

rabbitmqctl set_permissions -p / admin '.*' '.*' '.*'

could be turned into

$PREFIX/rabbitmqctl set_permissions -p / admin . .. .mkdir . .. .mkdir . .. .mkdir

"$*" would pass all parameters as a single string, which also doesn't work. Instead use $@, which passes the parameters as a list, and specifically "$@", which passes the parameters as a list without applying any expansions.

I also added "" around the exec paths, which might fix issues with spaces in the prefix. I haven't tested if that is an actual issue, but figured that adding them doesn't come with an extra cost.

Checklist

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Anthchirp commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.