Remove libgdal matrix, update to gdal 3.1

conda-forge / rasterio-feedstock

A conda-smithy repository for rasterio.

BSD 3-Clause "New" or "Revised" License

42 stars 22 forks source link

Remove libgdal matrix, update to gdal 3.1 #171

Closed xylar closed 3 years ago

xylar commented 3 years ago

Migrate to gdal 3.1, which didn't happen in #168

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xylar commented 3 years ago

@conda-forge-admin, please rerender

xylar commented 3 years ago

libgdal pins aren't getting updated.

xylar commented 3 years ago

@conda-forge/bot, it seems like the gdal migrator isn't updating libgdal pins. Has this been seen elsewhere? (If you are not the right group to ping, I apologize. Let me know who is.)

xylar commented 3 years ago

Updating just libgdal and not gdal seems to have worked fine in https://github.com/conda-forge/hexer-feedstock/pull/6 so I don't think it's something that simple.

xylar commented 3 years ago

I can manually update the pins under .ci_support if that will stick but want to leave this for now in case this helps with debugging the bot.

beckermr commented 3 years ago

The pins are being ignored due to the conda_build_config.yaml: https://github.com/conda-forge/rasterio-feedstock/blob/master/recipe/conda_build_config.yaml#L1

You'll need to figure out what is going on with that and possibly remove those entries. cc @ocefpaf who seems to have written those pins.

xylar commented 3 years ago

@beckermr, ah, of course! Thanks for pointing that out!

xylar commented 3 years ago

@conda-forge-admin, please rerender

xylar commented 3 years ago

Okay, upstream says gdal 3.1 isn't supported yet. Closing.

ocefpaf commented 3 years ago

Okay, upstream says gdal 3.1 isn't supported yet. Closing.

Yep. That is why we have a special pin here. Hopefully the next version will catch up.

akrherz commented 3 years ago

FWIW, I asked on the rasterio list about the status of rasterio 1.1.5 and GDAL 3.1 and Sean kindly chimed in that he is using that combo in production.

xylar commented 3 years ago

@akrherz, thanks for checking on that. It sounds promising. Let's hope there's a release in the not too distant future.

akrherz commented 3 years ago

Hi @xylar, I am unsure what is wrong with this PR then? Can't it be taken?

xylar commented 3 years ago

@akrherz, we only build releases so it doesn't really help us if the latest development version works with the latest gdal and proj. We could build a special dev version of the package if there is a release candidate or something like that.

xylar commented 3 years ago

@akrherz, sorry, I misunderstood. It sounds like we have the developer's blessing to violate the constraints he put on the dependency version. I'll revive this PR.