Closed xylar closed 3 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
I expect that some of the tests that were failing in previous releases will still be failing but I want to just skip those tests that we really have to.
@ocefpaf, I'm not sure what the decision making process was for skipping tests in the past. Presumably that it's easier to skip them than try to get them fixed upstream? I'm fine with that, just wanted to see.
I'm not sure what the decision making process was for skipping tests in the past.
It is a good idea to raise the issue upstream to check if you are unsure about anything.
It is a good idea to raise the issue upstream to check if you are unsure about anything.
Okay, thanks for the advice. The test I'm having to disable is test_boundless_fill_value_overview_masks
. I'll see if I can put together a minimum build process to reproduce the error and report upstream. I think pointing upstream to conda-forge CI or even a local conda build isn't likely to be very useful.
@conda-forge/rasterio, if you're okay with me removing the matrix of libgdal and disabling the test_boundless_fill_value_overview_masks
test for now, I think this is ready to merge. If there are concerns, I'm happy to address them. I will report the test issue upstream. I'm not good enough with Windows to try to report those issues upstream, though. I'll leave them for an expert if someone is interested.
I submitted the following issue upstream: https://github.com/mapbox/rasterio/issues/1999
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)This merge also cleans up dependencies (now that py27 is not supported) and updates the list of tests that are failing and will be skipped.
closes #174 closes #173