Closed xylar closed 3 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
In a test build on my Linux laptop, this simpler build worked fine. I want to see if it works under OSX and Windows, too.
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.
In my simple test to report testing issues from #175 upstream, I was having trouble with the pip install
command from build.sh
but was able to get the expected result (i.e. a rasterio
installation that passed all tests but the offending test_boundless_fill_value_overview_masks
) with the simpler command recommended in the conda-forge
docs:
{{ PYTHON }} -m pip install . --no-deps -vv
The same test worked on OSX, so I'm pretty confident in switching to this simple install command there, too. I'm hoping it will work for Windows, too, because I'm hopeless at debugging Windows problems...
Okay, it's not quite that simple. Working on it...
@conda-forge/rasterio, I tried to make the install script more consistent between unix
and win
but wasn't successful even after many hours. (As I said, not very good with win
.) But I think this update still includes some worthwhile improvements.
Please let me know if you have any concerns about the new script I added for determining the libgdal
version under win
. I think it should be reasonably robust (certainly more so than hand-coding the libgdal
version, which already failed when I didn't know I need to update it in my last PR). I will merge tomorrow if I don't hear objections.
I'm going to consider @ocefpaf's review sufficient. Thank you!
Hi! This is the friendly conda-forge automerge bot!
I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day!
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)This merge also adds a patch from upstream to fix the
test_boundless_fill_value_overview_masks
test (effectively disabling it for current gdal version).This merge also includes a new python script for using
conda list
to determine thelibgdal
version under Windows, where there is not another easy way to do this.