Closed regro-cf-autotick-bot closed 3 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
The failing test is:
=================================== FAILURES ===================================
__________________________ test_target_aligned_pixels __________________________
def test_target_aligned_pixels():
"""Issue 853 has been resolved"""
with rasterio.open("tests/data/world.rgb.tif") as src:
source = src.read(1)
profile = src.profile.copy()
dst_crs = "EPSG:3857"
with rasterio.Env(CHECK_WITH_INVERT_PROJ=False):
# Calculate the ideal dimensions and transformation in the new crs
dst_affine, dst_width, dst_height = calculate_default_transform(
src.crs, dst_crs, src.width, src.height, *src.bounds
)
dst_affine, dst_width, dst_height = aligned_target(
dst_affine, dst_width, dst_height, 100000.0
)
profile["height"] = dst_height
profile["width"] = dst_width
out = np.empty(shape=(dst_height, dst_width), dtype=np.uint8)
reproject(
source,
out,
src_transform=src.transform,
src_crs=src.crs,
dst_transform=dst_affine,
dst_crs=dst_crs,
resampling=Resampling.nearest,
)
# Check that there is no black borders
> assert out[:, 0].all()
E assert False
E + where False = <built-in method all of numpy.ndarray object at 0x7f5e57e04b70>()
E + where <built-in method all of numpy.ndarray object at 0x7f5e57e04b70> = array([72, 72, 72, ..., 0, 0, 0], dtype=uint8).all
tests/test_warp.py:1368: AssertionError
I didn't see an issue about this upstream but can make one.
It's pulling in proj
8.0.0, so that's probably related.
It's pulling in
proj
8.0.0, so that's probably related.
It should not :-/ there is an ongoing migration for that proj. I'll check it this afternoon.
It should not :-/ there is an ongoing migration for that proj. I'll check it this afternoon.
It's not a direct dependency, it's coming through libgdal
, so I think it's fine (it's not a bot problem).
We could see if #187 fixes this issue.
I ran tests on my Linux laptop. If I add proj <8.0.0
to the test requirements, the tests all pass. If I cherry-pick the migrator to libgdal
3.2 onto #187, the tests fail. If I then add proj <8.0.0` to the test requirements, they pass once again.
So I don't think rasterio
(or at least the tests) are 100% compatible with proj
8.0.0 but proj
is only a dependency through libgdal
, so that makes it maybe hard to justify constraining its version. Even so, maybe we should add it as an explicit dependency?
What do others think?
Due to the bot-rerun
label I'm closing this PR. I will make another one as appropriate. This was generated by
This PR has been triggered in an effort to update gdal32.
Notes and instructions for merging this PR:
Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.
This package has the following downstream children:
And potentially more.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever
) and pip (pip install re-ver
) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/615708357, please use this URL for debugging