conda-forge / rasterio-feedstock

A conda-smithy repository for rasterio.
BSD 3-Clause "New" or "Revised" License
42 stars 22 forks source link

Rebuild for gdal35 #242

Closed regro-cf-autotick-bot closed 2 years ago

regro-cf-autotick-bot commented 2 years ago

This PR has been triggered in an effort to update gdal35.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2406328210, please use this URL for debugging.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ngam commented 2 years ago

@conda-forge-admin please rerender

ngam commented 2 years ago

@conda-forge/rasterio some weird and potentially unrelated test failures? Any chance one of you could look into this?

ocefpaf commented 2 years ago

@conda-forge/rasterio some weird and potentially unrelated test failures? Any chance one of you could look into this?

I'll try to take a look over the weekend. rasterio and fiona have been quite hard to follow lately :-(

ngam commented 2 years ago

@ocefpaf don't go out of your way. I just noticed that this potentially can be blocking some things downstream and so I wanted to highlight it. If one of the maintainers can have a look at the errors and see if they are familiar / easy to figure it out, that would be great. But I can also give it a go later :) I know you're busier than usual these days, so no pressure

ngam commented 2 years ago

test_search_debian_gdal_data

mock_debian = local('/tmp/pytest-of-conda/pytest-0/test_search_debian_gdal_data0')

    def test_search_debian_gdal_data(mock_debian):
        """Find GDAL data under Debian locations"""
        finder = GDALDataFinder()
>       assert finder.search_debian(str(mock_debian)) == str(mock_debian.join("share").join("gdal").join("{}".format(str(gdal_version))))
E       AssertionError: assert None == '/tmp/pytest-of-conda/pytest-0/test_search_debian_gdal_data0/share/gdal/3.5'
E        +  where None = <bound method GDALDataFinder.search_debian of <rasterio._env.GDALDataFinder object at 0x7fddca507e10>>('/tmp/pytest-of-conda/pytest-0/test_search_debian_gdal_data0')
E        +    where <bound method GDALDataFinder.search_debian of <rasterio._env.GDALDataFinder object at 0x7fddca507e10>> = <rasterio._env.GDALDataFinder object at 0x7fddca507e10>.search_debian
E        +    and   '/tmp/pytest-of-conda/pytest-0/test_search_debian_gdal_data0' = str(local('/tmp/pytest-of-conda/pytest-0/test_search_debian_gdal_data0'))
E        +  and   '/tmp/pytest-of-conda/pytest-0/test_search_debian_gdal_data0/share/gdal/3.5' = str(local('/tmp/pytest-of-conda/pytest-0/test_search_debian_gdal_data0/share/gdal/3.5'))
E        +    where local('/tmp/pytest-of-conda/pytest-0/test_search_debian_gdal_data0/share/gdal/3.5') = <bound method LocalPath.join of local('/tmp/pytest-of-conda/pytest-0/test_search_debian_gdal_data0/share/gdal')>('3.5')
E        +      where <bound method LocalPath.join of local('/tmp/pytest-of-conda/pytest-0/test_search_debian_gdal_data0/share/gdal')> = local('/tmp/pytest-of-conda/pytest-0/test_search_debian_gdal_data0/share/gdal').join
E        +        where local('/tmp/pytest-of-conda/pytest-0/test_search_debian_gdal_data0/share/gdal') = <bound method LocalPath.join of local('/tmp/pytest-of-conda/pytest-0/test_search_debian_gdal_data0/share')>('gdal')
E        +          where <bound method LocalPath.join of local('/tmp/pytest-of-conda/pytest-0/test_search_debian_gdal_data0/share')> = local('/tmp/pytest-of-conda/pytest-0/test_search_debian_gdal_data0/share').join
E        +            where local('/tmp/pytest-of-conda/pytest-0/test_search_debian_gdal_data0/share') = <bound method LocalPath.join of local('/tmp/pytest-of-conda/pytest-0/test_search_debian_gdal_data0')>('share')
E        +              where <bound method LocalPath.join of local('/tmp/pytest-of-conda/pytest-0/test_search_debian_gdal_data0')> = local('/tmp/pytest-of-conda/pytest-0/test_search_debian_gdal_data0').join
E        +      and   '3.5' = <built-in method format of str object at 0x7fddcc3f6430>('3.5')
E        +        where <built-in method format of str object at 0x7fddcc3f6430> = '{}'.format
E        +        and   '3.5' = str(GDALVersion(major=3, minor=5))

test_search_gdal_data_debian

mock_debian = local('/tmp/pytest-of-conda/pytest-0/test_search_gdal_data_debian0')

    def test_search_gdal_data_debian(mock_debian):
        """Find GDAL data under Debian locations"""
        finder = GDALDataFinder()
>       assert finder.search(str(mock_debian)) == str(mock_debian.join("share").join("gdal").join("{}".format(str(gdal_version))))
E       AssertionError: assert None == '/tmp/pytest-of-conda/pytest-0/test_search_gdal_data_debian0/share/gdal/3.5'
E        +  where None = <bound method GDALDataFinder.search of <rasterio._env.GDALDataFinder object at 0x7fddc99ff710>>('/tmp/pytest-of-conda/pytest-0/test_search_gdal_data_debian0')
E        +    where <bound method GDALDataFinder.search of <rasterio._env.GDALDataFinder object at 0x7fddc99ff710>> = <rasterio._env.GDALDataFinder object at 0x7fddc99ff710>.search
E        +    and   '/tmp/pytest-of-conda/pytest-0/test_search_gdal_data_debian0' = str(local('/tmp/pytest-of-conda/pytest-0/test_search_gdal_data_debian0'))
E        +  and   '/tmp/pytest-of-conda/pytest-0/test_search_gdal_data_debian0/share/gdal/3.5' = str(local('/tmp/pytest-of-conda/pytest-0/test_search_gdal_data_debian0/share/gdal/3.5'))
E        +    where local('/tmp/pytest-of-conda/pytest-0/test_search_gdal_data_debian0/share/gdal/3.5') = <bound method LocalPath.join of local('/tmp/pytest-of-conda/pytest-0/test_search_gdal_data_debian0/share/gdal')>('3.5')
E        +      where <bound method LocalPath.join of local('/tmp/pytest-of-conda/pytest-0/test_search_gdal_data_debian0/share/gdal')> = local('/tmp/pytest-of-conda/pytest-0/test_search_gdal_data_debian0/share/gdal').join
E        +        where local('/tmp/pytest-of-conda/pytest-0/test_search_gdal_data_debian0/share/gdal') = <bound method LocalPath.join of local('/tmp/pytest-of-conda/pytest-0/test_search_gdal_data_debian0/share')>('gdal')
E        +          where <bound method LocalPath.join of local('/tmp/pytest-of-conda/pytest-0/test_search_gdal_data_debian0/share')> = local('/tmp/pytest-of-conda/pytest-0/test_search_gdal_data_debian0/share').join
E        +            where local('/tmp/pytest-of-conda/pytest-0/test_search_gdal_data_debian0/share') = <bound method LocalPath.join of local('/tmp/pytest-of-conda/pytest-0/test_search_gdal_data_debian0')>('share')
E        +              where <bound method LocalPath.join of local('/tmp/pytest-of-conda/pytest-0/test_search_gdal_data_debian0')> = local('/tmp/pytest-of-conda/pytest-0/test_search_gdal_data_debian0').join
E        +      and   '3.5' = <built-in method format of str object at 0x7fddcc3f61f0>('3.5')
E        +        where <built-in method format of str object at 0x7fddcc3f61f0> = '{}'.format
E        +        and   '3.5' = str(GDALVersion(major=3, minor=5))

test_info_azure_unsigned

monkeypatch = <_pytest.monkeypatch.MonkeyPatch object at 0x7fddc8e92e10>
runner = <click.testing.CliRunner object at 0x7fddc9455450>

    @requires_gdal32(reason="Unsigned Azure requests require GDAL ~= 3.2")
    @pytest.mark.network
    def test_info_azure_unsigned(monkeypatch, runner):
        """Unsigned access to public dataset works"""
        monkeypatch.setenv('AZURE_NO_SIGN_REQUEST', 'YES')
        monkeypatch.setenv('AZURE_STORAGE_ACCOUNT', 'naipblobs')
        result = runner.invoke(main_group, ['info', 'az://naip/v002/md/2017/md_100cm_2017/39077/m_3907744_ne_18_1_20170628.tif'])
>       assert result.exit_code == 0
E       AssertionError: assert 1 == 0
E        +  where 1 = <Result RasterioIOError('HTTP response code: 409')>.exit_code

tests/test_rio_info.py:436: AssertionError
ngam commented 2 years ago

TIL: GDAL 3.5 is not supported yet upstream? (according to readme)

Long issue with info here: https://github.com/rasterio/rasterio/issues/2310

ocefpaf commented 2 years ago

I believe that gdal 3.5 is supported but those tests do not look like the ones we should run in our feedstock ayways. I'm OK skipping them.