conda-forge / rasterio-feedstock

A conda-smithy repository for rasterio.
BSD 3-Clause "New" or "Revised" License
43 stars 23 forks source link

rasterio v1.3.0 #249

Closed regro-cf-autotick-bot closed 2 years ago

regro-cf-autotick-bot commented 2 years ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
boto3 1.24.23 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

Packages found in the meta.yaml but not found by source code inspection:

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2620007322, please use this URL for debugging.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

adamjstewart commented 2 years ago

Just a heads up, even after updating the dependencies, you'll still likely hit https://github.com/rasterio/rasterio/pull/2504. I tried tracking this down but ran out of energy/expertise. Excited to find out what might be causing that issue though.

xylar commented 2 years ago

@conda-forge-admin, please rerender

xylar commented 2 years ago

@adamjstewart, let's see how it goes. It seemed like the tests (except obviously for python 3.7) were passing fine for us. Are there tests that we're currently skipping that we no longer need to skip?

Update: I'm re-enabling all tests. Let's see what happens...

xylar commented 2 years ago

@adamjstewart. I'm disabling test_search_gdal_data_debian under Windows. All other tests are passing, which is amazing!!!

xylar commented 2 years ago

Hmm, still seeing a failure (one we've seen before) in Windows:

================================== FAILURES ===================================
_______________________ test_decimated_no_use_overview ________________________

self = <module 'py.error'>, func = <built-in function rename>
args = ('C:\\Users\\VssAdministrator\\AppData\\Local\\Temp\\pytest-of-VssAdministrator\\pytest-0\\test_decimated_no_use_overv...ministrator\\AppData\\Local\\Temp\\pytest-of-VssAdministrator\\pytest-0\\test_decimated_no_use_overview0\\red.tif.ovr')
kwargs = {}, __tracebackhide__ = False, cls = <class 'py.error.EEXIST'>
value = FileExistsError(17, 'Cannot create a file when that file already exists')
tb = <traceback object at 0x0000024DE3C42940>, errno = 17

    def checked_call(self, func, *args, **kwargs):
        """ call a function and raise an errno-exception if applicable. """
        __tracebackhide__ = True
        try:
>           return func(*args, **kwargs)
E           FileExistsError: [WinError 183] Cannot create a file when that file already exists: 'C:\\Users\\VssAdministrator\\AppData\\Local\\Temp\\pytest-of-VssAdministrator\\pytest-0\\test_decimated_no_use_overview0\\green.tif.ovr' -> 'C:\\Users\\VssAdministrator\\AppData\\Local\\Temp\\pytest-of-VssAdministrator\\pytest-0\\test_decimated_no_use_overview0\\red.tif.ovr'

..\_test_env\lib\site-packages\py\_error.py:66: FileExistsError

During handling of the above exception, another exception occurred:

red_green = local('C:\\Users\\VssAdministrator\\AppData\\Local\\Temp\\pytest-of-VssAdministrator\\pytest-0\\test_decimated_no_use_overview0')

    @requires_gdal33
    def test_decimated_no_use_overview(red_green):
        """Force ignore existing overviews when performing decimated read"""
        # Corrupt overview of red file by replacing red.tif.ovr with
        # green.tif.ovr.  We have a GDAL overview reading bug if green
        # pixels appear in a decimated read.
        green_ovr = red_green.join("green.tif.ovr")
>       green_ovr.move(red_green.join("red.tif.ovr"))

tests\test_overviews.py:133: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
..\_test_env\lib\site-packages\py\_path\common.py:213: in move
    self.rename(target)
..\_test_env\lib\site-packages\py\_path\local.py:459: in rename
    return py.error.checked_call(os.rename, self.strpath, target)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

self = <module 'py.error'>, func = <built-in function rename>
args = ('C:\\Users\\VssAdministrator\\AppData\\Local\\Temp\\pytest-of-VssAdministrator\\pytest-0\\test_decimated_no_use_overv...ministrator\\AppData\\Local\\Temp\\pytest-of-VssAdministrator\\pytest-0\\test_decimated_no_use_overview0\\red.tif.ovr')
kwargs = {}, __tracebackhide__ = False, cls = <class 'py.error.EEXIST'>
value = FileExistsError(17, 'Cannot create a file when that file already exists')
tb = <traceback object at 0x0000024DE3C42940>, errno = 17

    def checked_call(self, func, *args, **kwargs):
        """ call a function and raise an errno-exception if applicable. """
        __tracebackhide__ = True
        try:
            return func(*args, **kwargs)
        except self.Error:
            raise
        except (OSError, EnvironmentError):
            cls, value, tb = sys.exc_info()
            if not hasattr(value, 'errno'):
                raise
            __tracebackhide__ = False
            errno = value.errno
            try:
                if not isinstance(value, WindowsError):
                    raise NameError
            except NameError:
                # we are not on Windows, or we got a proper OSError
                cls = self._geterrnoclass(errno)
            else:
                try:
                    cls = self._geterrnoclass(_winerrnomap[errno])
                except KeyError:
                    raise value
>           raise cls("%s%r" % (func.__name__, args))
E           py.error.EEXIST: [File exists]: rename('C:\\Users\\VssAdministrator\\AppData\\Local\\Temp\\pytest-of-VssAdministrator\\pytest-0\\test_decimated_no_use_overview0\\green.tif.ovr', 'C:\\Users\\VssAdministrator\\AppData\\Local\\Temp\\pytest-of-VssAdministrator\\pytest-0\\test_decimated_no_use_overview0\\red.tif.ovr')

..\_test_env\lib\site-packages\py\_error.py:86: EEXIST

The easiest is to disable this but it would be good if the test could be fixed upstream to delete the files at the end of each test or use a unique name or directory for each test.

xylar commented 2 years ago

@conda-forge/rasterio and @adamjstewart, everyone okay with disabling the 2 failing tests and merging?

ocefpaf commented 2 years ago

I'm not sure the tests are run on Windows upstream. Even if they are, the name of the test calls for an exception :smile: