conda-forge / rasterio-feedstock

A conda-smithy repository for rasterio.
BSD 3-Clause "New" or "Revised" License
42 stars 22 forks source link

Update to v1.3.6 and rebuild for proj911 #259

Closed regro-cf-autotick-bot closed 1 year ago

regro-cf-autotick-bot commented 1 year ago

This PR has been triggered in an effort to update proj911.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3799003841, please use this URL for debugging.

closes #262 closes #260 closes #263

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

akrherz commented 1 year ago

Gonna try pushing some green builds through and beg forgiveness from others if this all blows up :)

akrherz commented 1 year ago

So we'd need to pin down gdal to 3.6.0 to make this work :( @xylar @ocefpaf , you folks have any thoughts? Just add a bunch of test skips?

xylar commented 1 year ago

@akrherz, I'm sorry, I don't have anything helpful to add. I appreciate you working on this.

akrherz commented 1 year ago

Here's my current thoughts and I plan to take this PR if it is green :)

My current env has rasterio 1.3.4 + GDAL 3.6.2 installed, since the CI passed when GDAL 3.6.0 was used for migration. It appears that CI is now failing with nothing else changed by GDAL 3.6.1 and 3.6.2 (perhaps I am wrong about that with some other transient dependency causing grief). Of course, the conda-forge pinning is anything 3.6.x, so it is likely more harm than good to pin this down to 3.6.0

I've engaged upstream on this and will perhaps learn something there with a PR I just submitted to get its CI testing against GDAL 3.6.2

So I don't believe that taking this PR will break anything worse than it already may be and it will at least clear up a dependency logjam with PROJ 9.1.1

xylar commented 1 year ago

@akrherz, while I don't have time to understand all the nuances, I'm very comfortable with proceeding as you suggest. I can try to help fix things if unexpected consequences arise.

xylar commented 1 year ago

Let's make sure to change the title of the PR to indicate that it's installing a newer version (not just updating the proj pin).

xylar commented 1 year ago

I'm also having this branch close the remaining 3 open PRs, as that seems to be the intention.

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

xylar commented 1 year ago

😭 Windows, how can you cause us so much trouble?!

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!