conda-forge / rasterio-feedstock

A conda-smithy repository for rasterio.
BSD 3-Clause "New" or "Revised" License
42 stars 22 forks source link

Test main branch rebuild with no changes #263

Closed akrherz closed 1 year ago

akrherz commented 1 year ago

Checklist

Would like to see if main branch even builds without any changes.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

akrherz commented 1 year ago

previous working main branch build appeared to be gdal 3.6.0 and proj 9.1.0

akrherz commented 1 year ago

Good, same failures as in #262, pinning down gdal to 3.6.0 now

akrherz commented 1 year ago

@conda-forge-admin please rerender

akrherz commented 1 year ago

Current GDAL 3.6.0 build 14 test failure

 ____________________ test_open_transform_gdal_geotransform _____________________

 path_rgb_byte_tif = '$SRC_DIR/tests/data/RGB.byte.tif'

     def test_open_transform_gdal_geotransform(path_rgb_byte_tif):
       """Passing a GDAL geotransform to rasterio.open(transform=...) should raise
         an exception.
        """
     with pytest.raises(TypeError):
             with rasterio.open(
                   path_rgb_byte_tif,
                     transform=tuple(affine.Affine.identity())):
 >               pass
 E               Failed: DID NOT RAISE <class 'TypeError'>

 tests/test_deprecated.py:18: Failed
weiji14 commented 1 year ago

Current GDAL 3.6.0 build 14 test failure

This test failure should have been fixed in rasterio 1.3.5, see the changelog at https://github.com/rasterio/rasterio/releases/tag/1.3.5, specifically commit https://github.com/rasterio/rasterio/commit/2fb7802b42a1893a7a729f2a6f78deb35229935f which updated the test to use:

        with rasterio.open(
-                path_rgb_byte_tif,
-                transform=tuple(affine.Affine.identity())):
+            path_rgb_byte_tif, transform=tuple(affine.Affine.identity().to_gdal())
+        ):
            pass

Maybe try running on rasterio 1.3.5 (#260) instead of the current main branch (rasterio 1.3.4) and see if it's ok?

akrherz commented 1 year ago

Thanks @weiji14 for chiming in! Build is green now :)

So does @conda-forge/rasterio have thoughts on what we should do here? Pin down GDAL to 3.6.0? Upstream is not testing the maint-1.3 branch against GDAL 3.6 it appears :/