conda-forge / ray-packages-feedstock

A conda-smithy repository for ray-packages.
BSD 3-Clause "New" or "Revised" License
10 stars 23 forks source link

ARM OSX Migrator #131

Closed regro-cf-autotick-bot closed 9 months ago

regro-cf-autotick-bot commented 11 months ago

This feedstock is being rebuilt as part of the ARM OSX migration.

Feel free to merge the PR if CI is all green, but please don't close it without reaching out the the ARM OSX team first at @conda-forge/help-osx-arm64.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7081287925, please use this URL for debugging.

conda-forge-webservices[bot] commented 11 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mattip commented 11 months ago

Getting a failure around cross compilation not using the correct python in build-core.sh but the line numbers do not match with the ones from this package. In any case, how do we acess the cross-compilation python?

/Users/runner/miniforge3/conda-bld/ray-packages_1701659063261/<path>/bin/python setup.py build
/Users/runner/miniforge3/conda-bld/ray-packages_1701659063261/work/build-core.sh: line 23: /Users/runner/miniforge3/conda-bld/ray-packages_1701659063261/<path>/bin/python: Bad CPU type in executable
h-vetinari commented 11 months ago

The upgrade-bot logic doesn't work well (or at all) for multi-output recipes. You'll need something like

    - python                                 # [build_platform != target_platform]
    - cross-python_{{ target_platform }}     # [build_platform != target_platform]

in the build environment of every output that wants to call into python (same goes for other tools being used like cython, etc.)

regro-cf-autotick-bot commented 9 months ago

I see that this PR has conflicts, and I'm the only committer. I'm going to close this PR and will make another one as appropriate. This was generated by https://github.com/regro/cf-scripts/actions/runs/7515104304