conda-forge / rdchiral_cpp-feedstock

A conda-smithy repository for rdchiral_cpp.
BSD 3-Clause "New" or "Revised" License
2 stars 4 forks source link

Migrate to Boost 1.78 #7

Closed conda-forge-linter closed 1 year ago

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I've rerendered the recipe as instructed in #6.

Here's a checklist to do before merging.

Fixes #6

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 1 year ago

@conda-forge-admin, please re-render

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/rdchiral_cpp-feedstock/actions/runs/3339502665.

jakirkham commented 1 year ago

Looks like maybe this is not necessary?

https://github.com/conda-forge/rdchiral_cpp-feedstock/blob/b03b5546e57215ecdb89e6a29fce4aad19b74c64/recipe/meta.yaml#L30-L31

That said, am not following the pinning here. Any clarification here would be appreciated 🙂

ljn917 commented 1 year ago

Looks like maybe this is not necessary?

https://github.com/conda-forge/rdchiral_cpp-feedstock/blob/b03b5546e57215ecdb89e6a29fce4aad19b74c64/recipe/meta.yaml#L30-L31

That said, am not following the pinning here. Any clarification here would be appreciated slightly_smiling_face

@jakirkham boost-python version format changed in 1.67 from boost-python3 to boost-python39 (minor version added). This requirement just simplifies the cmake file a bit. The code should work for pre-1.67 versions if the cmake file is also adapted according.

hadim commented 1 year ago

@ljn917 should we close here?

ljn917 commented 1 year ago

@hadim Yes, I believe so.