Remove rdkit-dev - Githubissues

conda-forge / rdkit-feedstock

A conda-smithy repository for rdkit.

BSD 3-Clause "New" or "Revised" License

8 stars 22 forks source link

Remove rdkit-dev #103

Open n-elie opened 2 years ago

n-elie commented 2 years ago

rdkit-dev was created because the Windows package was too big. #86 seems to have made the Windows build lighter. So rdkit-dev might not be useful anymore

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

rvianello commented 2 years ago

I'm wondering if this change could also indirectly address #60

mcs07 commented 2 years ago

I think this looks good?

Just to confirm - It looks like this keeps the rdkit-dev package, but basically as an empty wrapper around the updated rdkit package? That probably does make sense to avoid breaking things for people who currently depend on rdkit-dev.

Also, is there any way to see the package size before/after this change from the CI logs? Or would someone have to build locally to check?

carterbox commented 2 years ago

@mcs07, you can use the conda-forge.yml to make Azure store the build artifacts, then you can download them from the CI. store_build_artifacts: True

https://conda-forge.org/docs/maintainer/conda_forge_yml.html?highlight=conda+forge+yml#azure

@conda-forge/rdkit