Open n-elie opened 2 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
I'm wondering if this change could also indirectly address #60
I think this looks good?
Just to confirm - It looks like this keeps the rdkit-dev
package, but basically as an empty wrapper around the updated rdkit
package? That probably does make sense to avoid breaking things for people who currently depend on rdkit-dev
.
Also, is there any way to see the package size before/after this change from the CI logs? Or would someone have to build locally to check?
@mcs07, you can use the conda-forge.yml
to make Azure store the build artifacts, then you can download them from the CI. store_build_artifacts: True
https://conda-forge.org/docs/maintainer/conda_forge_yml.html?highlight=conda+forge+yml#azure
@conda-forge/rdkit
rdkit-dev was created because the Windows package was too big. #86 seems to have made the Windows build lighter. So rdkit-dev might not be useful anymore
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)