Fix rdkit location on osx-arm64

conda-forge / rdkit-feedstock

A conda-smithy repository for rdkit.

BSD 3-Clause "New" or "Revised" License

8 stars 21 forks source link

Fix rdkit location on osx-arm64 #121

Closed bkpoon closed 1 year ago

bkpoon commented 1 year ago

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[X] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Fixes #120

This PR removes the PYTHON_INSTDIR cmake argument which was set to $SP_DIR. During cross-compiling, $SP_DIR was always set to 3.10 instead of the specific Python version for the build.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bkpoon commented 1 year ago

@conda-forge-admin, please rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/rdkit-feedstock/actions/runs/3918294664.

mcs07 commented 1 year ago

Awesome! This feels like a bug in conda-build? Although good to see that SP_DIR isn't actually needed.

bkpoon commented 1 year ago

Thanks! I think the issue has something with the cross-compiling process where some environment variables are not updated. It's something I'll try to look into once I find some time.