search

conda-forge / rdkit-feedstock

A conda-smithy repository for rdkit.
BSD 3-Clause "New" or "Revised" License
8 stars 21 forks source link

Configuration for building a beta of the 2023.03.1 release #129

Closed greglandrum closed 1 year ago

greglandrum commented 1 year ago

Checklist

This is a first attempt to trigger builds of an preview (RC) build of the RDKit, per the discussion in #110

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

greglandrum commented 1 year ago

@conda-forge-admin, please rerender

greglandrum commented 1 year ago

@jaimergp this is my first attempt at triggering a pre-release build of the RDKit. Most of the changes are from merging main onto the pre branch. This is the one real commit: https://github.com/conda-forge/rdkit-feedstock/pull/129/commits/b80fca0ec67413e311ecf344df003e0d612e29fb

jaimergp commented 1 year ago

@conda-forge-admin, please rerender

jaimergp commented 1 year ago

macOS was failing with a missing symbol error. What SDK are you targeting? conda-forge defaults to 10.9.

greglandrum commented 1 year ago

macOS was failing with a missing symbol error. What SDK are you targeting? conda-forge defaults to 10.9.

Yeah, I saw that. I'm checking with @ptosco to see if he has any suggestions (he introduced the changes to the avalon toolkit which are causing this).

greglandrum commented 1 year ago

Yeah, I saw that. I'm checking with @ptosco to see if he has any suggestions (he introduced the changes to the avalon toolkit which are causing this).

Worst case we can just back that change out of this release.

greglandrum commented 1 year ago

@jaimergp :

macOS was failing with a missing symbol error. What SDK are you targeting? conda-forge defaults to 10.9.

Does it cause any problems for us to request a minimum SDK version of 10.13?

jaimergp commented 1 year ago

Nah, I think it's fine to request a higher version, but it has to be done explicitly via the config system. Check https://conda-forge.org/docs/maintainer/knowledge_base.html#requiring-newer-macos-sdks

jaimergp commented 1 year ago

@conda-forge-admin, please rerender

jaimergp commented 1 year ago

For the record, any change in conda_build_config.yaml or conda-forge.yml usually needs a rerender.

greglandrum commented 1 year ago

For the record, any change in conda_build_config.yaml or conda-forge.yml usually needs a rerender.

ah, damn. That would explain why the builds didn't look like anything changed. Let's see what happens now.

greglandrum commented 1 year ago

@jaimergp I'm going to do some more poking around to try and fix this, but in the meantime, is there some way to merge this and make the beta available even though the mac builds don't currently work?

jaimergp commented 1 year ago

You can skip the osx builds by doing this in meta.yaml:

...
build:
  ...
  skip: true  # [osx]

And rerender :)

greglandrum commented 1 year ago

@conda-forge-admin, please rerender

greglandrum commented 1 year ago

@jaimergp : the builds seem to work for linux and windows. Can we try whatever is required to get the beta builds deployed?

Once that's taken care of I can spend some time trying to fix whatever is going wrong on the macs (this needs to be done before the actual release anyway).

jaimergp commented 1 year ago

@greglandrum - if you are ready, click merge! The CI will run on pre and, this time, uploads will proceed to the configured label.

greglandrum commented 1 year ago

@jaimergp : the PR is merged, but it doesn't look like any label or new builds have appeared. Is there something else I need to do in order to make this work?

jaimergp commented 1 year ago

Github was having issues yesterday. Can you push an empty commit to the pre branch directly?

greglandrum commented 1 year ago

Github was having issues yesterday. Can you push an empty commit to the pre branch directly?

Done. Do I need to re-render again or can I expect it to just work?

greglandrum commented 1 year ago

Github was having issues yesterday. Can you push an empty commit to the pre branch directly?

Done. Do I need to re-render again or can I expect it to just work?

I wasn't patient enough (surprise surprise! 😉 )... at least the windows build worked. I will also check on linux and then announce the availability of the brea.

Thanks!