attempt numpy2 migration

conda-forge / rdkit-feedstock

A conda-smithy repository for rdkit.

BSD 3-Clause "New" or "Revised" License

8 stars 22 forks source link

attempt numpy2 migration #160

Closed greglandrum closed 2 months ago

greglandrum commented 2 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Following suggestions from here: https://github.com/conda-forge/rdkit-feedstock/pull/156#issuecomment-2218447961

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

greglandrum commented 2 months ago

@conda-forge-admin please rerender

greglandrum commented 2 months ago

@jaimergp @mcs07 @pstjohn I think this PR gets us set up to support numpy2.0 builds from conda-forge. It's ready for review

mcs07 commented 2 months ago

@conda-forge-admin please rerender

github-actions[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/rdkit-feedstock/actions/runs/9897313523.

jaimergp commented 2 months ago

Shall we wait for https://github.com/conda-forge/rdkit-feedstock/pull/158 before merging this one?

greglandrum commented 2 months ago

Shall we wait for #158 before merging this one?

I think it would be useful to get a version out there that supports numpy2.0 and given that #158 is a big one, it's hard for me to tell when it is going to be done.