conda-forge / rdkit-feedstock

A conda-smithy repository for rdkit.
BSD 3-Clause "New" or "Revised" License
8 stars 21 forks source link

Switch to clang for osx, add pytest for test running #161

Closed bp-kelley closed 3 months ago

bp-kelley commented 3 months ago

This fixes builds on osx. We need to use "clang" not "c" and purest is required for test running now.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

For recipe:

bp-kelley commented 3 months ago

Looks like something else was messed up on my system, I have it resolved now. We still may need pytest though

greglandrum commented 3 months ago

Looks like something else was messed up on my system, I have it resolved now. We still may need pytest though

I don't think that's likely: we don't run the python tests as part of the conda-forge builds. RDKit correctness is tested in the RDKit repository and we don't need to repeat that again here