Fix Windows DLL loading issue

conda-forge / rdkit-feedstock

A conda-smithy repository for rdkit.

BSD 3-Clause "New" or "Revised" License

8 stars 21 forks source link

Fix Windows DLL loading issue #169

Closed skearnes closed 2 months ago

skearnes commented 2 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hopefully a fix for #168

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

skearnes commented 2 months ago

@conda-forge-admin, please rerender

skearnes commented 2 months ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/rdkit-feedstock/actions/runs/10224325985.

greglandrum commented 2 months ago

I wasn't able to directly test that this produces working environments since build_locally.py doesn't work for windows environments and I can't figure out how to install the artifacts that the CI builds create, so I think it's worth merging this and seeing if it helps. The windows builds aren't going to get more broken, right? :shrug:

greglandrum commented 2 months ago

I have tested the update builds with python 3.9, 3.10, and 3.12 by doing the following and everything looks good:

conda create -n py310_rdkit python=3.10 rdkit
conda activate py310_rdkit
python -c "from rdkit import Chem"

I was getting the problems with DLL loading before, but things are fine now.

Thanks @skearnes

RMeli commented 2 months ago

GitHub CI with this latest version seems to work as expected (see https://github.com/RMeli/spyrmsd/pull/136). Thank you!