search

conda-forge / rdkit-feedstock

A conda-smithy repository for rdkit.
BSD 3-Clause "New" or "Revised" License
8 stars 22 forks source link

Switch to RDKit v2018.09.2 #26

Closed greglandrum closed 5 years ago

greglandrum commented 5 years ago

bump to the next RDKit release.

Q: I also bumped the build number. Not sure if that's right

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

greglandrum commented 5 years ago

@mcs07 @pstjohn : If I didn't get this right, please let me know

mcs07 commented 5 years ago

Hi Greg, there is a bot that has already opened a PR at #25. What you have done here looks all fine to me, except it seems the convention is to revert the build number back to zero for each new version. The bot has also done a 're-render' using the conda-smithy tool that generates these feedstock repositories, so that has also updated a lot of the CI scripts to their latest versions.

greglandrum commented 5 years ago

Ah, awesome. so I didn't need to do this at all and can close the PR, right?

mcs07 commented 5 years ago

Yep, feel free to close. I'll keep an eye on the bot PR and merge when all tests succeed. A couple have failed but I think it's just a HTTP error downloading the Avalon Toolkit, so should succeed when re-run.

greglandrum commented 5 years ago

Thanks Matt