rdkit v2019.03.1 - Githubissues

conda-forge / rdkit-feedstock

A conda-smithy repository for rdkit.

BSD 3-Clause "New" or "Revised" License

8 stars 21 forks source link

rdkit v2019.03.1 #30

Closed mcs07 closed 5 years ago

mcs07 commented 5 years ago

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

pstjohn commented 5 years ago

was this version where we wanted to build in a branch (#28)? I don't see a problem with building in master, I'd expect that python 2 installs would still pull the older versions of rdkit that support it.

mcs07 commented 5 years ago

Yeah this will be fine in master. The question was more about keeping an old 2018.09.x version around in a new branch. But I saw @greglandrum today and I think the conclusion was that it's not that important, as he doesn't envision doing many backports onto the 2018.09.x branch. Something that we can revisit in future if necessary I guess.