Add libs and headers in subpackage in windows

conda-forge / rdkit-feedstock

A conda-smithy repository for rdkit.

BSD 3-Clause "New" or "Revised" License

8 stars 22 forks source link

Add libs and headers in subpackage in windows #46

Closed n-elie closed 4 years ago

n-elie commented 4 years ago

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

This implement a subpackage with header and libs for Windows build. Should fix #36.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The top level meta keys are in an unexpected order. Expecting ['package', 'source', 'build', 'requirements', 'test', 'outputs', 'about', 'extra'].

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mcs07 commented 4 years ago

This seems like a pretty good solution to me.

@greglandrum - does this look alright to you? The additional rdkit-dev package only exists on Windows, and only contains the lib/*.lib and include/*.h files that were removed in #15 & #16. It depends on the rdkit package (which is unchanged), so conda install rdkit-dev will install both.

greglandrum commented 4 years ago

makes sense to me

n-elie commented 4 years ago

@conda-forge-admin, please rerender

n-elie commented 4 years ago

Is there anything I can do to improve this?

n-elie commented 4 years ago

Thanks for merging