Include headers from external folder in rdkit-dev

conda-forge / rdkit-feedstock

A conda-smithy repository for rdkit.

BSD 3-Clause "New" or "Revised" License

8 stars 22 forks source link

Include headers from external folder in rdkit-dev #47

Closed n-elie closed 4 years ago

n-elie commented 4 years ago

Checklist

[X] Used a fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[X] Ensured the license file is being packaged.

Just realized that all headers from External directory (in source) are not included in the newly created rdkit-dev subpackage. This PR is to fix that.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

n-elie commented 4 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

n-elie commented 4 years ago

There is still something I don't understand: the .lib files miss the "RDKit" prefix. For example, "Depictor.lib" should be name "RDKitDepictor.lib"

n-elie commented 4 years ago

Ok, my bad, Windows lib are not named with the RDKit prefix. PR is ready then