Closed jaimergp closed 4 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
<two spaces>#<one space>[<expression>]
form. See lines [22]We will need to add pycairo
to the migration. CF only has Linux / Win packages, but defaults does provide ppc64le
. We shouldn't take it from there though.
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
ppc64le
fails with:
[ 1%] Building CXX object Code/RDStreams/CMakeFiles/RDStreams.dir/streams.cpp.o
powerpc64le-conda_cos7-linux-gnu-c++: error: unrecognized command line option '-mpopcnt'; did you mean '-mpopcntb'?
make[2]: *** [Code/RDStreams/CMakeFiles/RDStreams.dir/build.make:80: Code/RDStreams/CMakeFiles/RDStreams.dir/streams.cpp.o] Error 1
However I don't see this option in build.sh
and I don't think the compilers include this unrecognized flag, so I guess it's part of rdkit
's CMake configuration?
--edit-- Yes, discussed here: https://github.com/rdkit/rdkit/issues/2405
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
Hi! This is the friendly automated conda-forge-linting service.
I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.
Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Local tests for ppc64le
and Python 3.7: build.log.zip
Two errors:
99% tests passed, 2 tests failed out of 180
Total Test time (real) = 538.96 sec
The following tests FAILED:
91 - test3D (Child aborted)
96 - pyMolDescriptors (Failed)
Ok, this should work on the next release. There's a subtle issue for ppc64le
that will be addressed in the next release. See https://github.com/rdkit/rdkit/pull/3285 for details.
I suggest waiting until then to update this PR and merge without patches.
@mcs07, @pstjohn, would you mind if I added myself as a maintainer?
Go for it! Thanks for all your work on this PR.
HTTP error in ppc64le, retrying...
There's a new error with CMake I am investigating.
Let's see if it was a weird conda solver issue.
Well, that did it! Ready for review @mcs07!
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)