bump to 2020.09.1 rdkit release

conda-forge / rdkit-feedstock

A conda-smithy repository for rdkit.

BSD 3-Clause "New" or "Revised" License

8 stars 21 forks source link

bump to 2020.09.1 rdkit release #59

Closed greglandrum closed 4 years ago

greglandrum commented 4 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

greglandrum commented 4 years ago

@conda-forge-admin, please rerender

jaimergp commented 4 years ago

All Windows builds are failing due to:

CMake Error at Code/GraphMol/MolDraw2D/CMakeLists.txt:42 (target_link_libraries):
  Cannot specify link libraries for target "MolDraw2D_static" which is not
  built by this project.

mcs07 commented 4 years ago

I think we can "solve" this by adding -D RDK_INSTALL_STATIC_LIBS=OFF ^ to bld.bat. It already has -D RDK_INSTALL_DEV_COMPONENT=OFF ^ (which I though did a similar thing?). Although this probably indicates something is not quite right in the CMake logic in how these two options interact.

greglandrum commented 4 years ago

Yeah, I think it's time to spend some quality time playing with build options and getting this straightened out. In the meantime I will try the change @mcs07 suggests.

jaimergp commented 4 years ago

Looks like that change does the trick for now!

mcs07 commented 4 years ago

Thanks for this Greg. Not sure why the bots didn't trigger this PR automatically.