conda-forge / rdkit-feedstock

A conda-smithy repository for rdkit.
BSD 3-Clause "New" or "Revised" License
8 stars 22 forks source link

rdkit v2020.09.2 #61

Closed regro-cf-autotick-bot closed 3 years ago

regro-cf-autotick-bot commented 3 years ago

It is very likely that the current package version for this feedstock is out of date. Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version. Checklist before merging this PR:
    • [ ] Dependencies have been updated if changed: see upstream
    • [ ] Tests have passed
    • [ ] Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/380580792, please use this URL for debugging

Here is a list of all the pending dependencies (and their versions) for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
rdkit 2020.09.2 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis of the source code shows a discrepancy between the library's imports and the package's stated requirements in the meta.yaml.

Packages found by inspection but not in the meta.yaml:

Packages found in the meta.yaml but not found by inspection:

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jaimergp commented 3 years ago

I guess most of those extra packages come from example scripts that use rdkit in the context of other tooling, but can you confirm @greglandrum? Also, do we still need six?

mcs07 commented 3 years ago

Looks to me like six isn't needed anymore - it was vendored into rdkit.six and even that isn't really used anymore now python 2 has been dropped.

I don't think it's necessary to include any of those other packages. Some are only required for building the docs, others are related to things in the Contrib directory, which is not built/installed by this recipe anyway.

greglandrum commented 3 years ago

Looks to me like six isn't needed anymore - it was vendored into rdkit.six and even that isn't really used anymore now python 2 has been dropped.

Yeah, six shouldn't be needed anymore and should just be removed completely from the RDKit. I'll deprecate it and possibly remove it for the next feature release (I have to guess what the odds are that it's being used downstream in client code).

greglandrum commented 3 years ago

I don't think it's necessary to include any of those other packages. Some are only required for building the docs, others are related to things in the Contrib directory, which is not built/installed by this recipe anyway.

Some of them - aggdraw, reportlab, matplotlib - are used in the RDKit sping interface and/or legacy drawing code. I would have guessed that there are people still using this, but given that the conda installs don't actually install them, it seems unlikely that people are using them. Others that are being used in modules which people may or may not be using:

jaimergp commented 3 years ago

What about this? We'll add:

Since MolVS is legacy, going to be removed and nobody has complained so far, I'd say we shouldn't add it?

jaimergp commented 3 years ago

Will merge today unless somebody disagrees!