Closed hadim closed 2 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge/rdkit should we pin boost
here?
It seems like the rebuild need this https://github.com/rdkit/rdkit/pull/4885 to work but it's not available for 2021.09.4.
We should be able to add https://patch-diff.githubusercontent.com/raw/rdkit/rdkit/pull/4885.patch as a patch within the recipe to fix this. Let me know @hadim if you'd like me to have a go at this on your PR here, or if you're OK to handle it.
Additionally, based on https://github.com/conda-forge/boost-cpp-feedstock/issues/114 we may also need to add zlib
as a host requirement?
Oh and we may soon be getting a new boost package anyway that fixes the problem? https://github.com/conda-forge/boost-cpp-feedstock/pull/115
Oh and we may soon be getting a new boost package anyway that fixes the problem? conda-forge/boost-cpp-feedstock#115
Indeed let's wait for that PR to be merged as it might fix the rdkit package.
I confirm boost-cpp 1.74 build 7 (from https://github.com/conda-forge/boost-cpp-feedstock/pull/115) fixes the issue for me so likely for the others too. Closing here.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)