conda-forge / rdkit-feedstock

A conda-smithy repository for rdkit.
BSD 3-Clause "New" or "Revised" License
8 stars 22 forks source link

New build to fix broken 2021.09.4 package #94

Closed hadim closed 2 years ago

hadim commented 2 years ago

Checklist

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hadim commented 2 years ago

See https://github.com/conda-forge/rdkit-feedstock/issues/93 and https://github.com/rdkit/rdkit/issues/4987 for details.

hadim commented 2 years ago

@conda-forge/rdkit should we pin boost here?

hadim commented 2 years ago

It seems like the rebuild need this https://github.com/rdkit/rdkit/pull/4885 to work but it's not available for 2021.09.4.

mcs07 commented 2 years ago

We should be able to add https://patch-diff.githubusercontent.com/raw/rdkit/rdkit/pull/4885.patch as a patch within the recipe to fix this. Let me know @hadim if you'd like me to have a go at this on your PR here, or if you're OK to handle it.

Additionally, based on https://github.com/conda-forge/boost-cpp-feedstock/issues/114 we may also need to add zlib as a host requirement?

mcs07 commented 2 years ago

Oh and we may soon be getting a new boost package anyway that fixes the problem? https://github.com/conda-forge/boost-cpp-feedstock/pull/115

hadim commented 2 years ago

Oh and we may soon be getting a new boost package anyway that fixes the problem? conda-forge/boost-cpp-feedstock#115

Indeed let's wait for that PR to be merged as it might fix the rdkit package.

hadim commented 2 years ago

I confirm boost-cpp 1.74 build 7 (from https://github.com/conda-forge/boost-cpp-feedstock/pull/115) fixes the issue for me so likely for the others too. Closing here.