search

conda-forge / re2-feedstock

A conda-smithy repository for re2.
BSD 3-Clause "New" or "Revised" License
2 stars 12 forks source link

Switch to C++17; compatible ABI with abseil #62

Closed h-vetinari closed 1 year ago

h-vetinari commented 1 year ago

Fixes #61 and establishes compatibility with C++17 abseil

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari commented 1 year ago

@conda-forge/re2

Unfortunately, re2's ABI depends on the C++ standard used to compile (more specifically, at least on the outcome of #ifdef __cpp_lib_string_view, see #61), and even more unfortunately, the current version is incompatible with the C++17 ABI of abseil.

Since fixing this changes ABI changes, I'm introducing a spurious (but tiny) version bump, which shouldn't be that much of an issue though since the version is YY-MM-DD. This would allows us to cleanly remigrate this package.

PTAL

h-vetinari commented 1 year ago

Gentle ping @conda-forge/re2. This is blocking some feedstocks like or-tools that need to use both abseil & re2, and cannot with the C++17 required for abseil.