Update rpy2 recipe to 3.0.5

conda-forge / rpy2-feedstock

A conda-smithy repository for rpy2.

BSD 3-Clause "New" or "Revised" License

3 stars 19 forks source link

Update rpy2 recipe to 3.0.5 #29

Closed EricR86 closed 5 years ago

EricR86 commented 5 years ago

Checklist

[x] Used a fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

EricR86 commented 5 years ago

@conda-forge-admin please rerender

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

EricR86 commented 5 years ago

Just an FYI I tried to re-render this locally using conda-smithy and I got the following problem:

$ conda smithy rerender -c auto
You appear to be using conda 4.7.11, but conda-smithy 3.1.12 is
currently only compatible with conda versions < 4.6.

I'm not sure how to re-render locally without having to downgrade conda.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

EricR86 commented 5 years ago

To the recipe maintainers: @ocefpaf @bgruening @ceholden @johanneskoester @mingwandroid

Sorry to ping you all like this. Currently when conda-forge upgraded it's version of numpy, the current rpy2 recipe broke and here was my attempt at replicating what the conda-forge bot would have done to upgrade the recipe.

Currently, the recipe breaks due to .patch files being now irrelevant. Not only that but the git log make it look like the patches were created and committed by Travis CI.

$ git log recipe/0001-ResetConsole_is_not_a_member_of_structRstart.patch
commit d4c2259e226cc8afe8b3f984ed433f1476a59885
Author: Travis-CI on github.com/conda-forge/staged-recipes <conda-forge@googlegroups.com>
Date:   Fri May 12 20:59:04 2017 +0000

    Initial feedstock commit with conda-smithy 2.3.1.

Any help getting this recipe up to date would be greatly appreciated!

ocefpaf commented 5 years ago

Sorry to ping you all like this.

BTW, you can do @conda-forge/rpy2 instead of the individual ping.

Currently when conda-forge upgraded it's version of numpy, the current rpy2 recipe broke and here was my attempt at replicating what the conda-forge bot would have done to upgrade the recipe.

Maybe we should try to build the current version with a numpy pin then.

Currently, the recipe breaks due to .patch files being now irrelevant. Not only that but the git log make it look like the patches were created and committed by Travis CI.

The author of those patches is probably @mingwandroid. The first step there is to try to removed them and check if they can be dropped (if they are upstream) or refresh (if we still need them).

ocefpaf commented 5 years ago

Closing this one in favor of #31. If you need the old version you can re-send this PR and I'll add a maintenance branch for the older version.