Fix running pytests during conda build.

conda-forge / rpy2-feedstock

A conda-smithy repository for rpy2.

BSD 3-Clause "New" or "Revised" License

3 stars 18 forks source link

Fix running pytests during conda build. #66

Closed matthewwardrop closed 4 years ago

matthewwardrop commented 4 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

I am currently blocked on this package being updated to R 4.0, and wanted to help out. So I spun up a docker container and poked around. The issue appears to be due to r-cairo not being present during the tests (specifically when testing the IPython magics which automatically set up the graphics environment), and then, with r-cairo now available, testing the svg arguments would fail due to no fonts being installed (thus this patch skips the svg args test).

With this patch things should start flowing again, and we can update to R 4.0!

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

matthewwardrop commented 4 years ago

@conda-forge-admin please rerender

dbast commented 4 years ago

No r-cairo available for aarch64 and pp64le.

matthewwardrop commented 4 years ago

Hmmm... So we can either universally disable a swathe of checks then, or selectively disable them only for arm. I'll patch this up tomorrow.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [62]

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

matthewwardrop commented 4 years ago

@dbast @ocefpaf Others? Should be ready to merge now. All builds have passed (there seems to be a stale/duplicate build here, probably because I pushed additional changes before the previous build finished).

ocefpaf commented 4 years ago

Thanks so much for taking care of this @matthewwardrop!

matthewwardrop commented 4 years ago

No worries @ocefpaf! Happy to help out if things go haywire again... just ping me!