conda-forge / rpy2-feedstock

A conda-smithy repository for rpy2.
BSD 3-Clause "New" or "Revised" License
3 stars 19 forks source link

Fix CFFI API mode binary RPATH. #77

Closed matthewwardrop closed 3 years ago

matthewwardrop commented 3 years ago

This patch fixes CFFI API mode when there is another R on the system path (that without this patch takes precedence). It works by inserting into the binary rpath the location of the R libraries. I have tested this on Linux and MacOS. (MacOS doesn't actually seem to need this patch, but it doesn't hurt either).

Note: There are some MacOS specific overrides that are not being used here. Is there a reason for this?

Checklist

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

matthewwardrop commented 3 years ago

@conda-forge-admin, please rerender

matthewwardrop commented 3 years ago

@dbast (others?) Mind if I add myself as a maintainer here?