search

conda-forge / ruby-feedstock

A conda-smithy repository for ruby.
BSD 3-Clause "New" or "Revised" License
1 stars 24 forks source link

remove feature? #90

Closed beckermr closed 2 years ago

beckermr commented 2 years ago

Our repodata patches remove the rb27 features attached to these builds.

See this diff: https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/issues/191

I think we should remove this from the build here?

cc @conda-forge/ruby @conda-forge/core

isuruf commented 2 years ago

No, the repodata patches should be fixed.

beckermr commented 2 years ago

So there are versions of ruby where we want the features and versions we do not?

beckermr commented 2 years ago

Ack nvm. I found the bug. I'll ship a pr to fix. Closing this!

beckermr commented 2 years ago

@isuruf see https://github.com/conda-forge/conda-forge-repodata-patches-feedstock/pull/192

comments welcome!

beckermr commented 2 years ago

I reopened this because I think the removal of the feature in the repodata patching was purposeful. The only instance of an rb2 feature I can find is for ruby

(base) clarence:Desktop beckermr$ wget https://conda.anaconda.org/conda-forge/linux-64/repodata_from_packages.json
--2021-11-29 11:44:45--  https://conda.anaconda.org/conda-forge/linux-64/repodata_from_packages.json
Resolving conda.anaconda.org (conda.anaconda.org)... 2606:4700::6811:5c18, 2606:4700::6811:5d18, 104.17.92.24, ...
Connecting to conda.anaconda.org (conda.anaconda.org)|2606:4700::6811:5c18|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 154744405 (148M) [application/json]
Saving to: ‘repodata_from_packages.json’

repodata_from_packages.json                100%[======================================================================================>] 147.58M  27.7MB/s    in 5.6s    

2021-11-29 11:44:51 (26.3 MB/s) - ‘repodata_from_packages.json’ saved [154744405/154744405]

(base) clarence:Desktop beckermr$ grep '"track_features": "rb2' repodata_from_packages.json 
      "track_features": "rb233",
      "track_features": "rb241",
      "track_features": "rb242",
      "track_features": "rb242",
      "track_features": "rb242",
      "track_features": "rb243",
      "track_features": "rb244",
      "track_features": "rb244",
      "track_features": "rb244",
      "track_features": "rb245",
      "track_features": "rb245",
      "track_features": "rb245",
      "track_features": "rb245",
      "track_features": "rb245",
      "track_features": "rb255",
      "track_features": "rb25",
      "track_features": "rb25",
      "track_features": "rb25",
      "track_features": "rb25",
      "track_features": "rb26",
      "track_features": "rb26",
      "track_features": "rb26",
      "track_features": "rb26",
      "track_features": "rb26",
      "track_features": "rb27",
      "track_features": "rb27",
      "track_features": "rb27",
      "track_features": "rb27",
      "track_features": "rb27",
      "track_features": "rb27",
      "track_features": "rb27",
      "track_features": "rb27",

Thus I think we should not make the feature in the build per the PR here: https://github.com/conda-forge/ruby-feedstock/pull/92

thoughts @isuruf @conda-forge/core?