rust 1.75.0 - Githubissues

conda-forge / rust-activation-feedstock

A conda-smithy repository for rust-activation.

BSD 3-Clause "New" or "Revised" License

0 stars 18 forks source link

Closed pavelzw closed 8 months ago

pavelzw commented 9 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 9 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

pavelzw commented 9 months ago

@conda-forge/rust-activation this is ready for review.

xhochy commented 8 months ago

@h-vetinari I would value your insight on this PR. This changes the minimal OSX version for rust to 10.12. Do you know how to correctly handle this?

h-vetinari commented 8 months ago

The CBC looks alright, you just need:

        - __osx >={{ MACOSX_DEPLOYMENT_TARGET }}  # [osx and x86_64]

under run: (or run_constrained:), so that the outputs themselves have the correct metadata as well.

h-vetinari commented 8 months ago

Ah, I hadn't gotten the detail that this is also about binaries produced by rust >=1.75. Thanks Isuru. :)

xhochy commented 8 months ago

Ah, I hadn't gotten the detail that this is also about binaries produced by rust >=1.75. Thanks Isuru. :)

Yes, that's why I was hesitant to merge here.

xhochy commented 8 months ago

@conda-forge-admin please rerender