update to 9.3 - Githubissues

conda-forge / sage-feedstock

A conda-smithy repository for sage.

BSD 3-Clause "New" or "Revised" License

7 stars 11 forks source link

update to 9.3 #64

Closed isuruf closed 3 years ago

isuruf commented 3 years ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

license_file entry is missing, but is required.

isuruf commented 3 years ago

@conda-forge-admin, rerender

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

license_file entry is missing, but is required.
noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

isuruf commented 3 years ago

@conda-forge-admin, rerender

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

license_file entry is missing, but is required.

isuruf commented 3 years ago

@conda-forge-admin, rerender.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

isuruf commented 3 years ago

This is a package with 100+ direct dependencies and 300+ indirect dependencies. It's also a meta-package that is noarch. (code is in sagelib conda package which has minimal deps and is used for building a few dependencies of sage and then sage is just a collection of sagelib package and other dependencies)

@conda-forge/core, this package doesn't build with conda-build, but does with conda-mambabuild. Since it's noarch, is it okay to use conda-mambabuild here? (I've tried debugging, but it's hard given that there are 300+ indirect dependencies)

beckermr commented 3 years ago

I'd be ok making an exception, but you'll have to edit the build scripts by hand. Smithy doesn't support uploads from mamba build.

isuruf commented 3 years ago

I'd be ok making an exception,

Thanks.

but you'll have to edit the build scripts by hand. Smithy doesn't support uploads from mamba build.

Sure. This should be a temporary measure and I'll try to debug it in the future.

isuruf commented 3 years ago

@conda-forge-admin, rerender