conda-forge / sagelib-feedstock

A conda-smithy repository for sagelib.
BSD 3-Clause "New" or "Revised" License
4 stars 8 forks source link

sagelib v10.3 #174

Closed regro-cf-autotick-bot closed 5 months ago

regro-cf-autotick-bot commented 7 months ago

Also fixes #172.

TODO
Dependencies
conda-forge-webservices[bot] commented 7 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

saraedum commented 7 months ago

It's maybe a good idea to use this opportunity to simplify the build script somewhat to what Arch does, https://github.com/sagemath/sage/issues/36860#issuecomment-1854730246

saraedum commented 6 months ago

@conda-forge-admin, please rerender

conda-forge-webservices[bot] commented 6 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-webservices[bot] commented 6 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

saraedum commented 6 months ago

@isuruf, there are a lot of warnings of the kind:

2024-04-23T00:51:14.8933508Z SafetyError: The package for sagelib located at /home/conda/feedstock_root/build_artifacts/pkg_cache/sagelib-10.3-py310h7f17788_0
2024-04-23T00:51:14.8934133Z appears to be corrupted. The path 'lib/python3.10/site-packages/sage/game_theory/__pycache__/cooperative_game.cpython-310.pyc'
2024-04-23T00:51:14.8934549Z has an incorrect size.
2024-04-23T00:51:14.8934864Z   reported size: 33136 bytes
2024-04-23T00:51:14.8935158Z   actual size: 33395 bytes

Is that anything to worry about?

saraedum commented 6 months ago

Also, I'm a bit surprised about this bit at the end of sagemath-bliss:

2024-04-23T00:50:41.5504111Z Successfully installed sagemath-bliss-10.3
2024-04-23T00:50:41.5530988Z 1 location(s) to search for versions of pip:
2024-04-23T00:50:41.5531684Z * https://pypi.org/simple/pip/
2024-04-23T00:50:41.5549678Z Fetching project page and analyzing links: https://pypi.org/simple/pip/
2024-04-23T00:50:41.5561786Z Getting page https://pypi.org/simple/pip/
2024-04-23T00:50:41.5576385Z Found index url https://pypi.org/simple/
2024-04-23T00:50:41.5598981Z Looking up "https://pypi.org/simple/pip/" in the cache
2024-04-23T00:50:41.5605688Z Request header has "max_age" as 0, cache bypassed
2024-04-23T00:50:41.5619977Z No cache entry available
2024-04-23T00:50:41.5634013Z Starting new HTTPS connection (1): pypi.org:443
2024-04-23T00:50:41.6060331Z https://pypi.org:443 "GET /simple/pip/ HTTP/1.1" 200 32567
2024-04-23T00:50:41.6093123Z Updating cache with response from "https://pypi.org/simple/pip/"
2024-04-23T00:50:41.6102241Z etag object cached for 1209600 seconds
2024-04-23T00:50:41.6109652Z Caching due to etag
2024-04-23T00:50:41.6169581Z Fetched page https://pypi.org/simple/pip/ as application/vnd.pypi.simple.v1+json
2024-04-23T00:50:41.6343034Z   Found link https://files.pythonhosted.org/packages/3d/9d/1e313763bdfb6a48977b65829c6ce2a43eaae29ea2f907c8bbef024a7219/pip-0.2.tar.gz (from https://pypi.org/simple/pip/), version: 0.2
[...]
saraedum commented 6 months ago

~Otherwise, this seems to be good to go.~ The linbox version is not correct.

alexjbest commented 6 months ago

@isuruf, there are a lot of warnings of the kind:

2024-04-23T00:51:14.8933508Z SafetyError: The package for sagelib located at /home/conda/feedstock_root/build_artifacts/pkg_cache/sagelib-10.3-py310h7f17788_0
2024-04-23T00:51:14.8934133Z appears to be corrupted. The path 'lib/python3.10/site-packages/sage/game_theory/__pycache__/cooperative_game.cpython-310.pyc'
2024-04-23T00:51:14.8934549Z has an incorrect size.
2024-04-23T00:51:14.8934864Z   reported size: 33136 bytes
2024-04-23T00:51:14.8935158Z   actual size: 33395 bytes

Is that anything to worry about?

Whenever I saw that error before as a user I ended up with a subtly broken install of sage, so this does seem a bit worrying to me!

isuruf commented 6 months ago

Does sage compile pyc files on first start manually?

saraedum commented 6 months ago

Does sage compile pyc files on first start manually?

I don't know. There's some weird stuff in the startup like a function that caches the result of * imports.

There's no reference to py_compile in SageMath ~10.2~ 10.3 at least.

saraedum commented 6 months ago

Since we seem to have no idea what's going on here, shall we just merge and test?

Any objections @isuruf, @alexjbest ?

saraedum commented 5 months ago

I'll just merge this then. If we find problems, we'll fix them later.