conda-forge / sagelib-feedstock

A conda-smithy repository for sagelib.
BSD 3-Clause "New" or "Revised" License
4 stars 8 forks source link

Use latest version of arb #88

Closed saraedum closed 4 years ago

saraedum commented 4 years ago

arb 2.17.0 has breaking API & ABI changes. Some obscure fmpr functions disappeared.

This should not affect sagelib.

saraedum commented 4 years ago

@isuruf: This is causing trouble for me with another project where I need new functionality available since 2.17.0.

I guess we should pin arb in conda-forge-pinning? How should I go about it? Just pin, or do I also need a migration here?

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

isuruf commented 4 years ago

I guess we should pin arb in conda-forge-pinning? How should I go about it? Just pin, or do I also need a migration here?

You need a migration since there are a few packages using arb (unless you want to send PRs by hand). See https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/368/files for an example.

saraedum commented 4 years ago

It's only sagelib/sage, e-antic, python-flint, and numcosmo. I'll do these by hand. (+normaliz which depends on e-antic.)

saraedum commented 4 years ago

I'll remove the pin once https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/385 has been merged.