conda-forge / scikit-bio-feedstock

A conda-smithy repository for scikit-bio.
BSD 3-Clause "New" or "Revised" License
0 stars 15 forks source link

MNT: Update for conda-build 3 #14

Closed conda-forge-linter closed 5 years ago

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-webservice.

I've updated the recipe for conda-build 3 as instructed in #13.

List of changes done to the recipe: Renamed build with host Removing pinnings for numpy to use values from conda_build_config.yaml. If you need the pin see here for details. Pinning numpy using pin_compatible. If you need to pin numpy to a specific version see here. Adding C compiler

Here's a checklist to do before merging.

Fixes #13 Closes #6 Closes #7

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 5 years ago

Seeing lots of failures like this...

======================================================================
ERROR: test_ancom_no_signal (skbio.stats.tests.test_composition.AncomTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/scikit-bio_1542772183900/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.6/site-packages/skbio/stats/tests/test_composition.py", line 934, in test_ancom_no_signal
    multiple_comparisons_correction=None)
  File "/home/conda/feedstock_root/build_artifacts/scikit-bio_1542772183900/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.6/site-packages/skbio/stats/composition.py", line 903, in ancom
    if np.any(table <= 0):
  File "/home/conda/feedstock_root/build_artifacts/scikit-bio_1542772183900/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.6/site-packages/pandas/core/generic.py", line 1121, in __nonzero__
    .format(self.__class__.__name__))
ValueError: The truth value of a Series is ambiguous. Use a.empty, a.bool(), a.item(), a.any() or a.all().

ref: https://circleci.com/gh/conda-forge/scikit-bio-feedstock/78

mortonjt commented 5 years ago

Those issues should have been squashed in the most recent version -- it should be just a matter of upgrading scikit-bio to version 0.5.5. We can submit and rerun this in a bit

cc @ElDeveloper