matplotlib-base plus bugfix backport

conda-forge / scikit-bio-feedstock

A conda-smithy repository for scikit-bio.

BSD 3-Clause "New" or "Revised" License

0 stars 15 forks source link

matplotlib-base plus bugfix backport #28

Closed Anthchirp closed 3 years ago

Anthchirp commented 3 years ago

Includes everything from #25 (which will automatically be marked as merged on merging this)

Failing build was caused by a newer version of numpy giving slightly different error messages. Changes were only needed in the tests.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Anthchirp commented 3 years ago

@conda-forge-admin, please rerender

Anthchirp commented 3 years ago

Looking good. Just to make sure I didn't inadvertently introduce something: @conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

Anthchirp commented 3 years ago

@conda-forge/scikit-bio Ready to review/merge 👍

ElDeveloper commented 3 years ago

Thanks so much @Anthchirp, are the main changes mostly focused on the patch to make the tests pass? And how should these be handled once we publish a new release of scikit-bio?

Anthchirp commented 3 years ago

Thanks so much @Anthchirp

you're welcome

are the main changes mostly focused on the patch to make the tests pass? And how should these be handled once we publish a new release of scikit-bio?

Yes, only the tests needed fixing. Once you make a new release you (or the auto-update bot) will create in a pull request here to build the updated package. Since the patches will no longer apply cleanly that pull request should break. At that stage all you need to do is remove the patches and delete the associated .patch file.

ElDeveloper commented 3 years ago

Great, thanks @Anthchirp.

@ebolyen or @thermokarst would anyone of you be able to review?

thermokarst commented 3 years ago

Thanks @Anthchirp & @ElDeveloper - I'll take a look at this today.

ElDeveloper commented 3 years ago

Thanks so much @Anthchirp & @thermokarst

thermokarst commented 3 years ago

Looks like the build failed, @Anthchirp. I don't have any more availability today to look into this, but will circle back in a few days.

Anthchirp commented 3 years ago

I've asked in gitter and the suggestion was to rerender once more and try again. I'll open a PR for that