conda-forge / scikit-bio-feedstock

A conda-smithy repository for scikit-bio.
BSD 3-Clause "New" or "Revised" License
0 stars 15 forks source link

Update meta.yaml #4

Closed RNAer closed 6 years ago

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 6 years ago

@conda-forge-admin, please rerender.

ebolyen commented 6 years ago

@RNAer @mortonjt, what's the current plan?

mortonjt commented 6 years ago

Not sure @ElDeveloper are these problems that you have seen before?

jakirkham commented 6 years ago

Also please update numpy to follow the latest guidelines.

ref: https://conda-forge.org/docs/meta.html#building-against-numpy

RNAer commented 6 years ago

@JakaKokosar , do you know why no linux build is launched in travis?

jakirkham commented 6 years ago

Linux builds are on CircleCI not Travis CI.

jakirkham commented 6 years ago

@conda-forge-admin, please rerender.

RNAer commented 6 years ago

Thanks, @jakirkham ! @jakirkham and @ebolyen , do you know what's going on for the error of circleci (shown below)? I have no idea how to fix it...

This application failed to start because it could not find or load the Qt platform plugin "xcb"
in "".

Available platform plugins are: minimal, offscreen, xcb.

Reinstalling the application may fix this problem.
/usr/bin/xvfb-run: line 181:   634 Aborted                 (core dumped) DISPLAY=:$SERVERNUM XAUTHORITY=$AUTHFILE "$@" 2>&1
RNAer commented 6 years ago

thanks, @ebolyen . you are sure that no extra dependencies are required for build? it looks travis failed because I deleted them.

jakirkham commented 6 years ago

Guess nose is needed at build time. Maybe just try adding that to see if it is enough.

jakirkham commented 6 years ago

LGTM

RNAer commented 6 years ago

thanks. ready to merge?

ebolyen commented 6 years ago

I think so!

mortonjt commented 6 years ago

Thanks guys!