search

conda-forge / scikit-image-feedstock

A conda-smithy repository for scikit-image.
BSD 3-Clause "New" or "Revised" License
4 stars 25 forks source link

Should scikit-image link against LLVM OpenMP instead of GNU OpenMP #69

Closed knedlsepp closed 3 years ago

knedlsepp commented 3 years ago

Issue: I don't have a minimal reproducer for this but I have the suspicion that linking against GNU OpenMP might the same undesired effects in scikit-image as was observed and fixed for OpenBLAS here: https://github.com/conda-forge/openblas-feedstock/pull/92

I'm thus wondering if an equivalent change should also be made here.

Ping @beckermr

knedlsepp commented 3 years ago

Similar issue for scikit-learn: https://github.com/conda-forge/scikit-learn-feedstock/issues/136

hmaarrfk commented 3 years ago

I don't think we explicitely link to either of them.

hmaarrfk commented 3 years ago

You should be able to switch in your environment https://conda-forge.org/docs/maintainer/knowledge_base.html?highlight=openmp#openmp

knedlsepp commented 3 years ago

Thx. I wasn't aware of that. It's still somewhat confusing for me that the openblas-feedstock explicitly mentions llvm-openmp as a build dependency when they could use the same mechanism. :thinking:

hmaarrfk commented 3 years ago

I'm really not sure, this stuff confuses me as well.

But if you are trying to hunt a bug that is affecting you, i wanted to point you in the right direction.