search

conda-forge / scikit-image-feedstock

A conda-smithy repository for scikit-image.
BSD 3-Clause "New" or "Revised" License
4 stars 25 forks source link

Dropping `toolz` and `cytoolz` from requirements #88

Open jakirkham opened 2 years ago

jakirkham commented 2 years ago

Now that dask-core includes toolz ( https://github.com/conda-forge/dask-core-feedstock/blob/2f6a5d945168b3ded6c1d7c37fbbf0780fcd205a/recipe/meta.yaml#L29 ) and Dask includes this in setup.py, think we can drop these from here

https://github.com/conda-forge/scikit-image-feedstock/blob/36299476c3302f544cdf61fe4330f0786abf3081/recipe/meta.yaml#L51-L55

hmaarrfk commented 2 years ago

i think that is reasonable. we can do this for 0.19.1 unless you want to make the PR. Do you know the minimum version to bump to?

jakirkham commented 2 years ago

The change was made in PR ( https://github.com/dask/dask/pull/7345 ), which was part of dask version 2021.03.1 (so released earlier this year)

No strong feelings on when/how this is done. Mostly raising for awareness that this simplification could be made 🙂

hmaarrfk commented 2 years ago

Ok thanks for the details. Yea, I remember when I looked into it I felt like it was "recent" but maybe it won't be in 6 months time or so. I'm also trying to interpret nep29 as it applies to dask.

The rules as I understood them provide:

$ pip install nep29
$ nep29 dask
|  version  |    date    |
|:---------:|:----------:|
| 2021.11.0 | 2021-11-05 |
| 2021.10.0 | 2021-10-22 |
|  2021.9.0 | 2021-09-03 |
|  2021.8.0 | 2021-08-13 |
|  2021.7.0 | 2021-07-09 |
|  2021.6.0 | 2021-06-04 |
|  2021.5.0 | 2021-05-14 |
|  2021.4.0 | 2021-04-02 |
|  2021.3.0 | 2021-03-05 |
|  2021.2.0 | 2021-02-05 |
|  2021.1.0 | 2021-01-15 |
| 2020.12.0 | 2020-12-11 |
|   2.30.0  | 2020-10-06 |
|   2.29.0  | 2020-10-02 |
|   2.28.0  | 2020-09-26 |
|   2.27.0  | 2020-09-19 |
|   2.26.0  | 2020-09-11 |
|   2.25.0  | 2020-08-28 |
|   2.24.0  | 2020-08-22 |
|   2.23.0  | 2020-08-14 |
|   2.22.0  | 2020-07-31 |
|   2.21.0  | 2020-07-17 |
|   2.20.0  | 2020-07-03 |
|   2.19.0  | 2020-06-19 |
|   2.18.0  | 2020-06-06 |
|   2.17.0  | 2020-05-27 |
|   2.16.0  | 2020-05-08 |
|   2.15.0  | 2020-04-25 |
|   2.14.0  | 2020-04-03 |
|   2.13.0  | 2020-03-25 |
|   2.12.0  | 2020-03-06 |
|   2.11.0  | 2020-02-19 |
|   2.10.0  | 2020-01-28 |
jakirkham commented 2 years ago

Since Dask isn't really using NEP 29 in this way, wouldn't hold Dask to this.