search

conda-forge / scipoptsuite-feedstock

A conda-smithy repository for scipoptsuite.
BSD 3-Clause "New" or "Revised" License
25 stars 13 forks source link

Scip v804 #43

Closed ju-manns closed 1 year ago

ju-manns commented 1 year ago

Checklist

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Documentation on acceptable licenses can be found here.

matbesancon commented 1 year ago

@AntoinePrv do you know what's going on in the installation step here:

2023-08-03T15:52:18.6189668Z -- The C compiler identification is GNU 12.3.0
2023-08-03T15:52:18.7310082Z -- The CXX compiler identification is GNU 12.3.0
2023-08-03T15:52:18.7519350Z -- Detecting C compiler ABI info
2023-08-03T15:52:18.8561270Z -- Detecting C compiler ABI info - done
2023-08-03T15:52:18.8812359Z -- Check for working C compiler: $PREFIX/bin/x86_64-conda-linux-gnu-cc - skipped
2023-08-03T15:52:18.8821830Z -- Detecting C compile features
2023-08-03T15:52:18.8833128Z -- Detecting C compile features - done
2023-08-03T15:52:18.8905589Z -- Detecting CXX compiler ABI info
2023-08-03T15:52:18.9930618Z -- Detecting CXX compiler ABI info - done
2023-08-03T15:52:19.0195041Z -- Check for working CXX compiler: $PREFIX/bin/x86_64-conda-linux-gnu-c++ - skipped
2023-08-03T15:52:19.0200098Z -- Detecting CXX compile features
2023-08-03T15:52:19.0210550Z -- Detecting CXX compile features - done
2023-08-03T15:52:19.0286697Z CMake Error at CMakeLists.txt:9 (find_package):
2023-08-03T15:52:19.0287328Z   By not providing "FindSCIP.cmake" in CMAKE_MODULE_PATH this project has
2023-08-03T15:52:19.0289015Z   asked CMake to find a package configuration file provided by "SCIP", but
2023-08-03T15:52:19.0289486Z   CMake did not find one.
2023-08-03T15:52:19.0289634Z 
2023-08-03T15:52:19.0289858Z   Could not find a package configuration file provided by "SCIP" with any of
2023-08-03T15:52:19.0290234Z   the following names:
2023-08-03T15:52:19.0290324Z 
2023-08-03T15:52:19.0290479Z     SCIPConfig.cmake
2023-08-03T15:52:19.0290750Z     scip-config.cmake
2023-08-03T15:52:19.0290839Z 
2023-08-03T15:52:19.0291029Z   Add the installation prefix of "SCIP" to CMAKE_PREFIX_PATH or set
2023-08-03T15:52:19.0291272Z   "SCIP_DIR" to a directory containing one of the above files.  If "SCIP"
2023-08-03T15:52:19.0291787Z   provides a separate development package or SDK, be sure it has been
2023-08-03T15:52:19.0291984Z   installed.
2023-08-03T15:52:19.0292067Z 
2023-08-03T15:52:19.0292136Z 
2023-08-03T15:52:19.0292373Z -- Configuring incomplete, errors occurred!
2023-08-03T15:52:19.6368467Z Tests failed for scip-8.0.4-h4a32fe0_0.conda - moving package to /home/conda/feedstock_root/build_artifacts/broken

not sure if some particular configuration / step is expected?

AntoinePrv commented 1 year ago

Looks like a test failing. The test example cannot find the SCIP CMake config files.

Looking at the installation, we have:

-- Installing: $PREFIX/lib64/libscip.so.8.0.4.0
-- Installing: $PREFIX/lib64/libscip.so.8.0
-- Installing: $PREFIX/lib64/libscip.so
-- Installing: $PREFIX/lib64/cmake/scip/scip-targets.cmake
-- Installing: $PREFIX/lib64/cmake/scip/scip-targets-release.cmake
-- Installing: $PREFIX/lib64/cmake/scip/scip-config.cmake

which is supposed to be under $PREFIX/lib (not lib64) in Conda. This can be controlled by CMAKE_INSTALL_LIBDIR. This is properly set in Conda-Froge's CMAKE_ARGS environment variable. You could try adding $CMAKE_ARGS (no quote) to the CLI arguments here. And similarily %CMAKE_ARGS% on Windows.

AntoinePrv commented 1 year ago

Gonna try out the PR locally

matbesancon commented 1 year ago

thanks @AntoinePrv !

ju-manns commented 1 year ago

Thank you @AntoinePrv :)